From: Kay Sievers <kay.sievers@vrfy.org>
To: Robert Love <rml@novell.com>
Cc: Greg KH <greg@kroah.com>, Anton Blanchard <anton@samba.org>,
linux-kernel@vger.kernel.org, davem@redhat.com,
herbert@gondor.apana.org.au
Subject: Re: [patch] kobject_uevent: fix init ordering
Date: Thu, 04 Nov 2004 20:04:02 +0100 [thread overview]
Message-ID: <1099595042.8249.23.camel@localhost.localdomain> (raw)
In-Reply-To: <1099592851.31022.145.camel@betsy.boston.ximian.com>
On Thu, 2004-11-04 at 13:27 -0500, Robert Love wrote:
> Greg!
>
> Looks like kobject_uevent_init is executed before netlink_proto_init and
> consequently always fails. Not cool.
>
> Attached patch switches the initialization over from core_initcall (init
> level 1) to postcore_initcall (init level 2). Netlink's initialization
> is done in core_initcall, so this should fix the problem. We should be
> fine waiting until postcore_initcall.
Looks good. Don't know why this never failed on any kernel I used.
Does the failure happens on a SMP kernel?
> static int send_uevent(const char *signal, const char *obj, const void *buf,
> - int buflen, int gfp_mask)
> + int buflen, int gfp_mask)
^^^^^^^^^^
This has changed and will not apply.
Best,
Kay
next prev parent reply other threads:[~2004-11-04 19:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-04 15:43 netlink vs kobject_uevent ordering Anton Blanchard
2004-11-04 18:05 ` Greg KH
2004-11-04 18:13 ` Robert Love
2004-11-04 19:32 ` David S. Miller
2004-11-04 18:27 ` [patch] kobject_uevent: fix init ordering Robert Love
2004-11-04 19:04 ` Kay Sievers [this message]
2004-11-04 19:11 ` Robert Love
2004-11-04 19:28 ` Robert Love
2004-11-04 20:07 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1099595042.8249.23.camel@localhost.localdomain \
--to=kay.sievers@vrfy.org \
--cc=anton@samba.org \
--cc=davem@redhat.com \
--cc=greg@kroah.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=rml@novell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox