From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Linux Kernel list <linux-kernel@vger.kernel.org>
Cc: Linus Torvalds <torvalds@osdl.org>,
"Antonino A. Daplas" <adaplas@hotpop.com>
Subject: Re: fbdev: fix compile of rivafb on __BIG_ENDIAN
Date: Mon, 08 Nov 2004 17:49:56 +1100 [thread overview]
Message-ID: <1099896596.5295.159.camel@gaston> (raw)
In-Reply-To: <200411080605.iA865Sr3009548@hera.kernel.org>
On Mon, 2004-11-08 at 04:36 +0000, Linux Kernel Mailing List wrote:
> ChangeSet 1.2606, 2004/11/07 20:36:41-08:00, torvalds@ppc970.osdl.org
>
> fbdev: fix compile of rivafb on __BIG_ENDIAN
>
> Typo introduced by latest cleanups by Antonino
>
>
>
> riva_hw.c | 2 +-
> 1 files changed, 1 insertion(+), 1 deletion(-)
>
>
> diff -Nru a/drivers/video/riva/riva_hw.c b/drivers/video/riva/riva_hw.c
> --- a/drivers/video/riva/riva_hw.c 2004-11-07 22:05:40 -08:00
> +++ b/drivers/video/riva/riva_hw.c 2004-11-07 22:05:40 -08:00
> @@ -2112,7 +2112,7 @@
> #ifdef __BIG_ENDIAN
> /* turn on big endian register access */
> if(!(NV_RD32(chip->PMC, 0x00000004) & 0x01000001))
> - NV_WR32(chip->PMC, 0x00000004], 0x01000001);
> + NV_WR32(chip->PMC, 0x00000004, 0x01000001);
> #endif
Since the NV_* macros now use byteswapping readX/writeX, we probably
want to remove the above bits completely... I suspect as-is, the driver
no longer works on ppc, but then, I don't have nVidia HW to test any
more.
Ben.
parent reply other threads:[~2004-11-08 6:51 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <200411080605.iA865Sr3009548@hera.kernel.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1099896596.5295.159.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=adaplas@hotpop.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox