* Re: fbdev: fix compile of rivafb on __BIG_ENDIAN
[not found] <200411080605.iA865Sr3009548@hera.kernel.org>
@ 2004-11-08 6:49 ` Benjamin Herrenschmidt
0 siblings, 0 replies; only message in thread
From: Benjamin Herrenschmidt @ 2004-11-08 6:49 UTC (permalink / raw)
To: Linux Kernel list; +Cc: Linus Torvalds, Antonino A. Daplas
On Mon, 2004-11-08 at 04:36 +0000, Linux Kernel Mailing List wrote:
> ChangeSet 1.2606, 2004/11/07 20:36:41-08:00, torvalds@ppc970.osdl.org
>
> fbdev: fix compile of rivafb on __BIG_ENDIAN
>
> Typo introduced by latest cleanups by Antonino
>
>
>
> riva_hw.c | 2 +-
> 1 files changed, 1 insertion(+), 1 deletion(-)
>
>
> diff -Nru a/drivers/video/riva/riva_hw.c b/drivers/video/riva/riva_hw.c
> --- a/drivers/video/riva/riva_hw.c 2004-11-07 22:05:40 -08:00
> +++ b/drivers/video/riva/riva_hw.c 2004-11-07 22:05:40 -08:00
> @@ -2112,7 +2112,7 @@
> #ifdef __BIG_ENDIAN
> /* turn on big endian register access */
> if(!(NV_RD32(chip->PMC, 0x00000004) & 0x01000001))
> - NV_WR32(chip->PMC, 0x00000004], 0x01000001);
> + NV_WR32(chip->PMC, 0x00000004, 0x01000001);
> #endif
Since the NV_* macros now use byteswapping readX/writeX, we probably
want to remove the above bits completely... I suspect as-is, the driver
no longer works on ppc, but then, I don't have nVidia HW to test any
more.
Ben.
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2004-11-08 6:51 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <200411080605.iA865Sr3009548@hera.kernel.org>
2004-11-08 6:49 ` fbdev: fix compile of rivafb on __BIG_ENDIAN Benjamin Herrenschmidt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox