From: "Darrick J. Wong" <djwong@us.ibm.com>
To: Linus Torvalds <torvalds@osdl.org>
Cc: linux-aio@kvack.org, Andrew Morton <akpm@osdl.org>,
Kernel Mailing List <linux-kernel@vger.kernel.org>,
Suparna Bhattacharya <suparna@in.ibm.com>
Subject: Re: [PATCH] Oops in aio_free_ring on 2.6.9
Date: Mon, 08 Nov 2004 11:30:12 -0800 [thread overview]
Message-ID: <1099942211.12365.372.camel@bluebox> (raw)
In-Reply-To: <Pine.LNX.4.58.0411061938150.2223@ppc970.osdl.org>
On Sat, 2004-11-06 at 19:43, Linus Torvalds wrote:
> I don't disagree with the bug, but I disagree with the fix.
>
> In my opinion, the problem is that "info->nr_pages" is _wrong_. It's wrong
> because it has been initialized to a bogus value.
>
> I'd much prefer this alternate appended patch. Can you verify that it also
> fixes the problem (we can drop the bogus info->nr_pages initialization,
You're right, that is a better fix. The aio code is not my current area
of expertise, as I've demonstrated. :)
Your patch also fixes the problem.
Thanks,
--Darrick
prev parent reply other threads:[~2004-11-08 19:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-05 19:34 [PATCH] Oops in aio_free_ring on 2.6.9 Darrick J. Wong
2004-11-07 3:43 ` Linus Torvalds
2004-11-08 4:17 ` Suparna Bhattacharya
2004-11-08 19:30 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1099942211.12365.372.camel@bluebox \
--to=djwong@us.ibm.com \
--cc=akpm@osdl.org \
--cc=linux-aio@kvack.org \
--cc=linux-kernel@vger.kernel.org \
--cc=suparna@in.ibm.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox