From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34CFBC7EE2F for ; Sun, 11 Jun 2023 12:30:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232720AbjFKMah (ORCPT ); Sun, 11 Jun 2023 08:30:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47692 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229562AbjFKMae (ORCPT ); Sun, 11 Jun 2023 08:30:34 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 54DE210CF; Sun, 11 Jun 2023 05:30:31 -0700 (PDT) Received: from [192.168.10.54] (unknown [119.152.150.198]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: usama.anjum) by madras.collabora.co.uk (Postfix) with ESMTPSA id CD7DF660574E; Sun, 11 Jun 2023 13:30:27 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1686486629; bh=HHdqWR2okT6f26fW1zbq1QsrSlpeo2mcJTuQUDuClkw=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=GJl0QNiLNl8GF6nN2GckWewBetb/dGrtGkiHBh94JFUSP2+k5aQa0W5xjSg/pw+g/ kxaJskEwwzEktuXQz7Vg6yr/zV5DQpdpHn4UI8sT495SGgdwOrjeaUJfttfOajX51Y 3NYWqAs6KI2hpAmnNIzTnNJOfrs/uOkyQ26nX2EjWbR+kVlGPiSsbu3EOSDMeQ2XQO 9PDHWknjFVtduWH9or7+6c4Y5XPTW7WH2zzvopdsCtEwYnRG+3yXaFQjS/7vfcHtzH OKl8QYKyqnuP5xOe/lPDuBAWQTLWAt41AcqzTT7KM4DgqvMctVFTSzkSdBdKTr8AdC fxXrHof3yhmAg== Message-ID: <109d9c47-9c0e-e8ca-2bc1-cb741bc45a1b@collabora.com> Date: Sun, 11 Jun 2023 17:30:22 +0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Cc: Muhammad Usama Anjum , Shuah Khan , linux-kernel@vger.kernel.org, Peter Xu , Andrew Morton , linux-mm@kvack.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v1 1/1] selftests: mm: uufd-unit-tests: remove a format warning in printf Content-Language: en-US To: Mirsad Todorovac References: <20230610235016.438460-1-mirsad.todorovac@alu.unizg.hr> From: Muhammad Usama Anjum In-Reply-To: <20230610235016.438460-1-mirsad.todorovac@alu.unizg.hr> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The fix has already been picked up by Andew in mm unstable: https://lore.kernel.org/all/20230607023727.0E011C433D2@smtp.kernel.org On 6/11/23 4:50 AM, Mirsad Todorovac wrote: > GCC 11.3.0 issued warnings about macros and types of arguments [edited]: > > gcc -Wall -I ../tools/testing/selftests/../../.. \ > -I ../tools/testing/selftests/../../../tools/include/uapi \ > -isystem ../usr/include -no-pie uffd-unit-tests.c vm_util.c \ > uffd-common.c -lrt -lpthread -o \ > ../tools/testing/selftests/mm/uffd-unit-tests > uffd-unit-tests.c: In function ‘main’: > uffd-unit-tests.c:1198:41: warning: format not a string literal and no \ > format arguments [-Wformat-security] > 1198 | uffd_test_start(test_name); > | ^~~~~~~~~ > uffd-unit-tests.c:100:24: note: in definition of macro ‘uffd_test_start’ > 100 | printf(__VA_ARGS__); \ > | ^~~~~~~~~~~ > uffd-unit-tests.c:1205:33: warning: format not a string literal and no \ > format arguments [-Wformat-security] > 1205 | uffd_test_skip(errmsg); > | ^~~~~~~~~~~~~~ > > The macros are defined as: > > #define uffd_test_start(...) do { \ > printf("Testing "); \ > printf(__VA_ARGS__); \ > printf("... "); \ > fflush(stdout); \ > } while (0) > > #define uffd_test_skip(...) do { \ > printf("skipped [reason: "); \ > printf(__VA_ARGS__); \ > printf("]\n"); \ > ksft_inc_xskip_cnt(); \ > } while (0) > > Minor workaround, adding "%s" first argument to macro expansion calls seems > to be the easiest way to eliminate the warnings. > > Cc: Peter Xu > Cc: linux-mm@kvack.org > Cc: linux-kselftest@vger.kernel.org > Fixes: 43759d44dc34 ("selftests/mm: add uffdio register ioctls test") > Fixes: 16a45b57cbf2 ("selftests/mm: add framework for uffd-unit-test") > Signed-off-by: Mirsad Todorovac > --- > tools/testing/selftests/mm/uffd-unit-tests.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/mm/uffd-unit-tests.c b/tools/testing/selftests/mm/uffd-unit-tests.c > index 269c86768a02..d356dd271c84 100644 > --- a/tools/testing/selftests/mm/uffd-unit-tests.c > +++ b/tools/testing/selftests/mm/uffd-unit-tests.c > @@ -1195,14 +1195,14 @@ int main(int argc, char *argv[]) > snprintf(test_name, sizeof(test_name), > "%s on %s", test->name, mem_type->name); > > - uffd_test_start(test_name); > + uffd_test_start("%s", test_name); > if (!uffd_feature_supported(test)) { > uffd_test_skip("feature missing"); > continue; > } > if (uffd_setup_environment(&args, test, mem_type, > &errmsg)) { > - uffd_test_skip(errmsg); > + uffd_test_skip("%s", errmsg); > continue; > } > test->uffd_fn(&args); -- BR, Muhammad Usama Anjum