From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D86A9C5AD4C for ; Thu, 23 Nov 2023 17:52:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345748AbjKWRwc (ORCPT ); Thu, 23 Nov 2023 12:52:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44976 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229462AbjKWRwa (ORCPT ); Thu, 23 Nov 2023 12:52:30 -0500 Received: from out-178.mta1.migadu.com (out-178.mta1.migadu.com [IPv6:2001:41d0:203:375::b2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B68211F for ; Thu, 23 Nov 2023 09:52:35 -0800 (PST) Message-ID: <10c4ae94-525f-4ac1-9d59-80bb4f7d362e@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1700761953; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xOb7IjDCHemslGdU76yEhf/PgAy4hmseLlpzuv6m1Uk=; b=rvDAMlYFJTRFccWgNKvskgLlDUt2EAgJ4/69cFY/PQwIb4RbG+p4JSMlgU56VNnRzt7Ej/ XGTJwyXbrBl07dUi7GAgFTfAovsKn7cIWeKdVhlgQVsEFKFnEjGl2fuWQSpgeGHofR1A+m PZ13xFlJRMw+z7THsKTVSDQc9Bh/pyY= Date: Fri, 24 Nov 2023 01:52:26 +0800 MIME-Version: 1.0 Subject: Re: [PATCH 8/8] drm/bridge: it66121: Allow link this driver as a lib Content-Language: en-US To: Dmitry Baryshkov Cc: Phong LE , Neil Armstrong , Maxime Ripard , Sui Jingfeng , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Laurent Pinchart , Thomas Zimmermann References: <20231114150130.497915-1-sui.jingfeng@linux.dev> <20231114150130.497915-9-sui.jingfeng@linux.dev> <79301d04-c0cb-4740-8a6d-27a889b65daf@linux.dev> <121163c9-0d56-47ad-a12e-e67390fef2b4@linux.dev> <00ba2245-0e48-4b21-bcd4-29dfb728e408@linux.dev> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Sui Jingfeng In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 2023/11/23 16:08, Dmitry Baryshkov wrote: >> I'm agree with the idea that drm bridges drivers involved toward to a direction >> that support more complex design, but I think we should also leave a way for the >> most frequent use case. Make it straight-forward as a canonical design. > Not having anything connector-related in the drm_bridge driver is a > canonical design. What you said is just for the more complex uses case. I can't agree, sorry. By choosing the word "canonical design", I means that the most frequently used cases in practice are the canonical design, 95+% motherboards I have seen has only one *onboard* display bridges chip. For my driver, I abstract the internal (inside of the chip) encoder as drm_encoder and abstract the external TX chip as drm_bridge, this design still works very well. Originally, I means that this is a concept of the hardware design. You are wrong even through in the software design context, the transparent simple drm bridge drivers(simple-bridge.c) also *allow* to create drm connector manually. I don't think I need to emulate more example, please read the code by youself. Canonical or not canonical is not a question to argue, if other programmers are allowed to do such kind of abstraction, I should also allowed too. Thanks.