From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailout2.samsung.com (mailout2.samsung.com [203.254.224.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A2023ED3CA for ; Tue, 30 Jun 2026 11:28:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=203.254.224.25 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782818923; cv=none; b=oDH+ydS/q2VzRVr6WFfMJpAsxhJhe8eWlBuNGE67XdZOvU0/80/ViSRz3reYeop/AeJyXa6n0JpIdmNoSf19nQoljzpDEWSAly3oOgle6aYqemk8YWvZLF6nbN+8qhaOwdRUyAGnNfZ28R5uTaS1yqWdPdjxzQ8yjyuZAZf+E9E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782818923; c=relaxed/simple; bh=WBlom0iDPCVsCjE864JxXWp8X0m3OrVlX25asskwS8g=; h=From:To:Cc:In-Reply-To:Subject:Date:Message-ID:MIME-Version: Content-Type:References; b=aE60WlnPUxFA1nqAJFMxfpb69pMHCSy3++BQYHYisCaUMcdNQLTxUeMFH0aLYu3zkaaZYjcYivDAL5d9GK/XCn/sn9CW4ycFPmNj/dBWqAFZs5NRdmbZ5l2z1zuiBdky77453ruBDe/id8auwLBzn68frMDy7IQLfh8okp5iH/w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com; spf=pass smtp.mailfrom=samsung.com; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b=N8CMIt18; arc=none smtp.client-ip=203.254.224.25 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=samsung.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="N8CMIt18" Received: from epcas5p3.samsung.com (unknown [182.195.41.41]) by mailout2.samsung.com (KnoxPortal) with ESMTP id 20260630112838epoutp0258f4b31746f14e506c0c0939c363cfd0~92Fw410VO1235612356epoutp02- for ; Tue, 30 Jun 2026 11:28:38 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.samsung.com 20260630112838epoutp0258f4b31746f14e506c0c0939c363cfd0~92Fw410VO1235612356epoutp02- DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1782818918; bh=WBlom0iDPCVsCjE864JxXWp8X0m3OrVlX25asskwS8g=; h=From:To:Cc:In-Reply-To:Subject:Date:References:From; b=N8CMIt18qyqh4UyXXu6C2pgNITJJ3eLl/7VDzD0CpSERHQiRJMwiN7Jmlssm0yWb6 +Us5ntXEs0j374OaCF5zkXsDgxbhrpnHoOLZaO+faHvRo880HqpzkRw9FRERxHM3EE 6KyEDpAJ6Awe4ZEXTpsv2TxSHatLGCXmvS3UsMgo= Received: from epsnrtp01.localdomain (unknown [182.195.42.153]) by epcas5p4.samsung.com (KnoxPortal) with ESMTPS id 20260630112837epcas5p42699c74e7bdfdc08e7a387ecddd1610f~92FwTOXXd2430624306epcas5p4W; Tue, 30 Jun 2026 11:28:37 +0000 (GMT) Received: from epcas5p3.samsung.com (unknown [182.195.38.87]) by epsnrtp01.localdomain (Postfix) with ESMTP id 4gqLW83pG4z6B9m9; Tue, 30 Jun 2026 11:28:36 +0000 (GMT) Received: from epsmtip1.samsung.com (unknown [182.195.34.30]) by epcas5p4.samsung.com (KnoxPortal) with ESMTPA id 20260630112836epcas5p49964fca2cb45fb07d2bbd7f3a7dfcbf1~92FvDdikf2430624306epcas5p4U; Tue, 30 Jun 2026 11:28:36 +0000 (GMT) Received: from INBRO002756 (unknown [107.122.3.168]) by epsmtip1.samsung.com (KnoxPortal) with ESMTPA id 20260630112833epsmtip1093e0631eef1002d20979d73c9441641~92FsWGGhq1723317233epsmtip1E; Tue, 30 Jun 2026 11:28:33 +0000 (GMT) From: "Alim Akhtar" To: "'Krzysztof Kozlowski'" , "'Peter Griffin'" Cc: "'Denzeel Oliva'" , "'Sylwester Nawrocki'" , "'Chanwoo Choi'" , "'Michael Turquette'" , "'Stephen Boyd'" , "'Brian Masney'" , "'Rob Herring'" , "'Conor Dooley'" , , , , , In-Reply-To: Subject: RE: [PATCH v3 3/3] clk: samsung: exynos990: Fix PERIS gate clock parents Date: Tue, 30 Jun 2026 16:58:31 +0530 Message-ID: <10d301dd0883$970925c0$c51b7140$@samsung.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQEx4sfAWwy4gnk+MuXqAo8FFpNhngGTah19AjUYwH4DLBf1wQK+JwWqAckmQ8cBG1pq6bdIhjIw Content-Language: en-us X-CMS-MailID: 20260630112836epcas5p49964fca2cb45fb07d2bbd7f3a7dfcbf1 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" CMS-TYPE: 105P cpgsPolicy: CPGSC10-543,Y X-CFilter-Loop: Reflected X-CMS-RootMailID: 20260629123246epcas5p2aab9da9ef417274bb0b70f74c386f7b4 References: <20260613-exynos990-peris-fix-v3-v3-0-2b230db78ae4@gmail.com> <20260613-exynos990-peris-fix-v3-v3-3-2b230db78ae4@gmail.com> <0f1e01dd0844$01190c40$034b24c0$@samsung.com> > -----Original Message----- > From: Krzysztof Kozlowski > Sent: Tuesday, June 30, 2026 4:43 PM > To: Peter Griffin ; Alim Akhtar > > Cc: Denzeel Oliva ; Sylwester Nawrocki > ; Chanwoo Choi ; > Michael Turquette ; Stephen Boyd > ; Brian Masney ; Rob Herring > ; Conor Dooley ; linux-samsung- > soc=40vger.kernel.org; linux-clk=40vger.kernel.org; > devicetree=40vger.kernel.org; linux-arm-kernel=40lists.infradead.org; lin= ux- > kernel=40vger.kernel.org > Subject: Re: =5BPATCH v3 3/3=5D clk: samsung: exynos990: Fix PERIS gate c= lock > parents >=20 > On 30/06/2026 13:02, Peter Griffin wrote: > > Hi Alim, > > > > On Tue, 30 Jun 2026 at 04:53, Alim Akhtar > wrote: > >> > >> > >> > >>> -----Original Message----- > >>> From: Peter Griffin > >>> Sent: Monday, June 29, 2026 6:02 PM > >>> To: Denzeel Oliva > >>> Cc: Krzysztof Kozlowski ; Sylwester Nawrocki > >>> ; Chanwoo Choi > ; Alim > >>> Akhtar ; Michael Turquette > >>> ; Stephen Boyd ; Brian > >>> Masney ; Rob Herring ; > Conor > >>> Dooley ; linux-samsung-soc=40vger.kernel.org; > >>> linux- clk=40vger.kernel.org; devicetree=40vger.kernel.org; linux-arm= - > >>> kernel=40lists.infradead.org; linux-kernel=40vger.kernel.org > >>> Subject: Re: =5BPATCH v3 3/3=5D clk: samsung: exynos990: Fix PERIS ga= te > >>> clock parents > >>> > >>> Hi Krysztof & Denzeel, > >>> > >>> On Sat, 13 Jun 2026 at 13:36, Denzeel Oliva > >>> > >>> wrote: > >>>> > >>>> Correct eight PERIS gate clock parents to match the hardware clock > >>>> tree and reorder the GIC mux parents so mout_peris_bus_user is the > >>>> default source. > >>>> > >>>> Signed-off-by: Denzeel Oliva > >>>> --- > >>> > >>> Reviewed-by: Peter Griffin > >>> > >>> =40Krysztof: I was thinking, maybe we should establish a new rule/bes= t > >>> practice for Samsung clock upstream submissions whereby patch > >>> contributors should link to the downstream cal-if code for the SoC > >>> after the -- > >>> - line. That would make reviewing the patches' correctness a bit > >>> easier, as the downstream cal-if code would be readily available to t= he > reviewer. > >>> > >> We can leave this choice to the reviewer if they want to refer to > downstream cal-if code. > > > > Generally I would like to, but I also don't have time to hunt around > > the internet for a downstream kernel tree. My rationale was that the > > submitter is most likely to know where the downstream code is, and is > > likely using it for the upstream clock implementation. So, linking to > > it as part of the submission should hopefully be fairly easy. > > > > If it is a Samsung SoC for which no public code is available that's > > fine. I didn't intend this to be a hard requirement: =22you can't > > upstream x,y,z unless you link to the cal-if code=22. I meant it more a= s > > =22best practice/guidance=22; if the cal-if code is publicly available, > > linking to it would be a useful reference for reviewers. >=20 > cal-if as vendor tree? Some contributors just base their work on downstre= am > GPL-compliance dumps from opensource.samsung.com, so not sure how > that link would work. >=20 Right, I am not against adding any best practice guideline, but I wonder on= ly few of us will end up reviewing those patches.=20 And for other reviewer, cal-if will add more confusion as it is completely = out of =7Btree / clk subsystem=7D interface.=20 > Best regards, > Krzysztof