From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: ACJfBouKmM7S5BBhdN/HvdrfBRNPQIlo5JNkNhivSSH+CA870BigjpqAI71dkN/FtVPdBjJ1PdEC ARC-Seal: i=1; a=rsa-sha256; t=1516371446; cv=none; d=google.com; s=arc-20160816; b=K2DnxL45yghRDqu0rCMMTS9snhMSnxeqofB7EQfpAsohjljYsSe2t2l96igY8ea7hq vNT+43SMNTM4XXga5EwBMGdbyXVKbB/zek6CT5e4uFzxs6S2QQwmkaXJUDQgNvZd145n 8nDfN8WmoRq08dKt4/y/4gHZYwupU1nYiwW78oFfKkXpqUsVykHB3t2i/4PDlJV3B9eU o7xAQS7Km2fqr1kovF71RgAnyVdliTxQUsQp5pEKvO5p5VCcSUn7UmpcBKUVohfYgAO8 HR3bY7gym11B2eo410QQSWcQU18jSMjUUg2aJnD49Q39w2EpPqzXrCTJ0V43j7gHny1w dRdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject:dmarc-filter :dkim-signature:dkim-signature:arc-authentication-results; bh=KcKNEpP2juWP7p1hvxywyS24PZ7qMfViCrBrgkCj/pU=; b=jWzJRkhqM3prksVcUE0H9fzVlfbeKWo9A5SUHZqWBtWOnz5HCNspyJoAJIh/A/IT+S QFM771006u41G/P04Bks922X5mCe1+YFX/LIWjjQ6HFR6JsMl1jNGFNq8TftmqTnIL4X sqJC1QC6+7q4jctFHX66hmxwUucIJrgUjC4hdf2nx+4nkrb2iD9WMZXPhJzqUxrxagKN +gzNiJRgusIy3zeA7e+XviAHslu6cXB9Ph0SGw/9peg//6vGVJSk70fYHF1YTGjJ262R pyRgpijcgqkNdUM7WPvrYXq0+iM3Zu1B/wDZU7YmwTE3btx05VW0x7fluxfT/N78/gNM 6Cfw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=M7JU6L8u; dkim=pass header.i=@codeaurora.org header.s=default header.b=Gs1c1nkE; spf=pass (google.com: domain of okaya@codeaurora.org designates 198.145.29.96 as permitted sender) smtp.mailfrom=okaya@codeaurora.org Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=M7JU6L8u; dkim=pass header.i=@codeaurora.org header.s=default header.b=Gs1c1nkE; spf=pass (google.com: domain of okaya@codeaurora.org designates 198.145.29.96 as permitted sender) smtp.mailfrom=okaya@codeaurora.org DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 3E29760376 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=okaya@codeaurora.org Subject: Re: [PATCH v6 7/7] PCI: Unify wait for link active into generic pci To: Oza Pawandeep , Bjorn Helgaas , Philippe Ombredanne , Thomas Gleixner , Greg Kroah-Hartman , Kate Stewart , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Dongdong Liu , Keith Busch , Wei Zhang , Timur Tabi References: <1516360204-1586-1-git-send-email-poza@codeaurora.org> <1516360204-1586-8-git-send-email-poza@codeaurora.org> From: Sinan Kaya Message-ID: <10da80a3-e058-1a21-7af2-405c99b7991e@codeaurora.org> Date: Fri, 19 Jan 2018 09:17:23 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <1516360204-1586-8-git-send-email-poza@codeaurora.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1590018961580197637?= X-GMAIL-MSGID: =?utf-8?q?1590030706005708118?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On 1/19/2018 6:10 AM, Oza Pawandeep wrote: > +++ b/drivers/pci/pcie/pcie-dpc.c > @@ -150,37 +150,9 @@ static void dpc_wait_link_inactive(struct dpc_dev *dpc) > struct pci_dev *pdev = dpc->dev->port; > struct device *dev = &dpc->dev->device; > u16 lnk_status; > + bool active = false; > > - pcie_capability_read_word(pdev, PCI_EXP_LNKSTA, &lnk_status); > - while (lnk_status & PCI_EXP_LNKSTA_DLLLA && > - !time_after(jiffies, timeout)) { > - msleep(10); > - pcie_capability_read_word(pdev, PCI_EXP_LNKSTA, &lnk_status); > - } > - if (lnk_status & PCI_EXP_LNKSTA_DLLLA) > - dev_warn(dev, "Link state not disabled for DPC event\n"); > -} I think you should reorder 6 and 7 to eliminate this. -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.