From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: WangYuli <wangyuli@uniontech.com>
Cc: david.e.box@linux.intel.com, Hans de Goede <hdegoede@redhat.com>,
platform-driver-x86@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
tzimmermann@suse.de, lee.jones@linaro.org, lee@kernel.org,
guanwentao@uniontech.com, zhanjun@uniontech.com
Subject: Re: [PATCH v2] platform/x86/intel/pmt: Correct the typo 'ACCCESS_LOCAL'
Date: Fri, 20 Sep 2024 17:14:42 +0300 (EEST) [thread overview]
Message-ID: <10db0939-a273-7a84-dcc9-c9b70ff7cc64@linux.intel.com> (raw)
In-Reply-To: <CE6FFCA273A3A016+20240920140901.30524-1-wangyuli@uniontech.com>
[-- Attachment #1: Type: text/plain, Size: 1686 bytes --]
On Fri, 20 Sep 2024, WangYuli wrote:
> There is a spelling mistake of 'ACCCESS_LOCAL' which should be
> 'ACCESS_LOCAL'.
>
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Suggested-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Did I actually suggest the change this patch makes somewhere? I recall
noting the typo at one point myself but I don't remember telling anyone
about it.
Reviewing your patch does not itself count as a reason for adding
Suggested-by (unless the entire approach used in the patch is changed
because of a reviewer comment which is not the case here).
--
i.
> Link: https://lore.kernel.org/all/26b8f38f-ff32-81fb-bbe5-aa141239427e@linux.intel.com/
> Signed-off-by: WangYuli <wangyuli@uniontech.com>
> ---
> drivers/platform/x86/intel/pmt/class.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/intel/pmt/class.c b/drivers/platform/x86/intel/pmt/class.c
> index c04bb7f97a4d..7680474c4f96 100644
> --- a/drivers/platform/x86/intel/pmt/class.c
> +++ b/drivers/platform/x86/intel/pmt/class.c
> @@ -207,7 +207,7 @@ static int intel_pmt_populate_entry(struct intel_pmt_entry *entry,
> /*
> * Some hardware use a different calculation for the base address
> * when access_type == ACCESS_LOCAL. On the these systems
> - * ACCCESS_LOCAL refers to an address in the same BAR as the
> + * ACCESS_LOCAL refers to an address in the same BAR as the
> * header but at a fixed offset. But as the header address was
> * supplied to the driver, we don't know which BAR it was in.
> * So search for the bar whose range includes the header address.
>
prev parent reply other threads:[~2024-09-20 14:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-20 14:09 [PATCH v2] platform/x86/intel/pmt: Correct the typo 'ACCCESS_LOCAL' WangYuli
2024-09-20 14:14 ` Ilpo Järvinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10db0939-a273-7a84-dcc9-c9b70ff7cc64@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=david.e.box@linux.intel.com \
--cc=guanwentao@uniontech.com \
--cc=hdegoede@redhat.com \
--cc=lee.jones@linaro.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=tzimmermann@suse.de \
--cc=wangyuli@uniontech.com \
--cc=zhanjun@uniontech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox