From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01F6CC433E0 for ; Thu, 4 Jun 2020 11:08:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DCF77206C3 for ; Thu, 4 Jun 2020 11:08:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726209AbgFDLIi (ORCPT ); Thu, 4 Jun 2020 07:08:38 -0400 Received: from smtprelay0052.hostedemail.com ([216.40.44.52]:40118 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725881AbgFDLIh (ORCPT ); Thu, 4 Jun 2020 07:08:37 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay07.hostedemail.com (Postfix) with ESMTP id 0B734181D3030; Thu, 4 Jun 2020 11:08:36 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: sand99_0e162d926d96 X-Filterd-Recvd-Size: 3513 Received: from XPS-9350.home (unknown [47.151.136.130]) (Authenticated sender: joe@perches.com) by omf18.hostedemail.com (Postfix) with ESMTPA; Thu, 4 Jun 2020 11:08:34 +0000 (UTC) Message-ID: <10e54ee84bd44171ef329bed9e7e6a946bae61ba.camel@perches.com> Subject: Re: [PATCH] pinctrl: pxa: pxa2xx: Remove 'pxa2xx_pinctrl_exit()' which is unused and broken From: Joe Perches To: Julia Lawall Cc: Dan Carpenter , Linus Walleij , Christophe JAILLET , Robert Jarzmik , Daniel Mack , Haojian Zhuang , Linux ARM , "open list:GPIO SUBSYSTEM" , "linux-kernel@vger.kernel.org" , kernel-janitors@vger.kernel.org Date: Thu, 04 Jun 2020 04:08:32 -0700 In-Reply-To: References: <20200531073716.593343-1-christophe.jaillet@wanadoo.fr> <87h7vvb1s3.fsf@belgarion.home> <20200601183102.GS30374@kadam> <20200604083120.GF22511@kadam> <2aa49a543e6f48a6f428a37b63a06f9149870225.camel@perches.com> <32232229031e02edcc268b1074c9bac44012ee35.camel@perches.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.36.2-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2020-06-04 at 12:33 +0200, Julia Lawall wrote: > > On Thu, 4 Jun 2020, Joe Perches wrote: > > > On Thu, 2020-06-04 at 11:52 +0200, Julia Lawall wrote: > > > Should Fixes also be used when the change will make it hard to port other > > > fixes over it? > > > > If it's a logic defect or regression that's being fixed, > > shouldn't the logic defect or regression be fixed as > > reasonably soon as possible? > > Sure, but I recall seeing some patches that mentioned that the problem had > existed since the beginning of git. Of course, it should be rare. git history goes back 15 years already. There are scant few bugs that old. There is a tree with even older history that Rob Landley still has here: https://landley.net/kdocs/fullhist/ It does make git blame research a bit easier for those rare and extremely old defects. > > The nature of the fix should ideally be optimal for > > backporting, but I believe that should not stop any > > consideration for the standalone fix itself. > > I'm not sure to follow this. I think it comes down to defects in current need to be fixed. Describing the base commit that is being fixed is useful for backporting. I believe it's not reasonable to ask the author of a fix to research how it could or should be backported. > Sometimes non-bug fixes that block > backporting a bug fix have to be backported as well. So the fixes would > again highlight the range of versions affected by the issue. Sure, but the non-bug fixes that may also need backporting to enable easy backports of the actual fix should not be described in the Fixes: as those are generally easily researched from a command like: $ git log .. by whoever needs to backport.