From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: ben-linux@fluff.org, Jean Delvare <khali@linux-fr.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] i2c: fix xiic build error
Date: Tue, 2 Mar 2010 21:36:40 +0100 [thread overview]
Message-ID: <10f740e81003021236i662aa20fs7e092295f07aecd4@mail.gmail.com> (raw)
In-Reply-To: <10f740e81002221103h7408d52ajf5a67da39d6ae8dd@mail.gmail.com>
On Mon, Feb 22, 2010 at 20:03, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> On Mon, Feb 22, 2010 at 17:36, Randy Dunlap <randy.dunlap@oracle.com> wrote:
>> On 02/16/10 08:36, Randy Dunlap wrote:
>>> On 02/16/10 08:33, Jean Delvare wrote:
>>>> On Tue, 16 Feb 2010 08:07:05 -0800, Randy Dunlap wrote:
>>>>> On 02/04/10 12:11, Randy Dunlap wrote:
>>>>>
>>>>> This patch is still needed in linux-next-20100216.
>>>>
>>>> Nothing I can do about it, as the i2c-xiic driver is neither upstream
>>>> nor in my tree.
>>>
>>> Thanks, Jean.
>>>
>>> Next/merge.log tells me:
>>> Merge remote branch 'bjdooks-i2c/next-i2c'
>>>
>>> Ben??
>>>
>>
>> ping Ben.
>
> Yes, please. Thx!
Ping? This build problem is almost one month old now...
>> Here's the patch again.
>>
>> ---
>> From: Randy Dunlap <randy.dunlap@oracle.com>
>>
>> Add header file to fix build error:
>>
>> drivers/i2c/busses/i2c-xiic.c:493: error: implicit declaration of function 'mdelay'
>>
>> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
>> Cc: "Ben Dooks (embedded platforms)" <ben-linux@fluff.org>
>> Cc: linux-i2c@vger.kernel.org
>> ---
>> drivers/i2c/busses/i2c-xiic.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> --- linux-next-20100204.orig/drivers/i2c/busses/i2c-xiic.c
>> +++ linux-next-20100204/drivers/i2c/busses/i2c-xiic.c
>> @@ -31,6 +31,7 @@
>> #include <linux/module.h>
>> #include <linux/init.h>
>> #include <linux/errno.h>
>> +#include <linux/delay.h>
>> #include <linux/platform_device.h>
>> #include <linux/i2c.h>
>> #include <linux/interrupt.h>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2010-03-02 20:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-04 7:57 linux-next: Tree for February 4 Stephen Rothwell
2010-02-04 20:11 ` [PATCH -next] i2c: fix xiic build error Randy Dunlap
2010-02-16 16:07 ` Randy Dunlap
2010-02-16 16:33 ` Jean Delvare
2010-02-16 16:36 ` Randy Dunlap
2010-02-22 16:36 ` Randy Dunlap
2010-02-22 19:03 ` Geert Uytterhoeven
2010-03-02 20:36 ` Geert Uytterhoeven [this message]
2010-02-04 20:12 ` [PATCH -next] pci hotplug: fix ibmphp " Randy Dunlap
2010-02-08 18:50 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10f740e81003021236i662aa20fs7e092295f07aecd4@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=ben-linux@fluff.org \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).