From: Marcel Holtmann <marcel@holtmann.org>
To: Andries Brouwer <Andries.Brouwer@cwi.nl>
Cc: Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] remove explicit k_name use in atmel_cs.c, bt3c_cs.c
Date: Wed, 10 Nov 2004 02:15:18 +0100 [thread overview]
Message-ID: <1100049318.25879.13.camel@pegasus> (raw)
In-Reply-To: <20041110005941.GA9336@apps.cwi.nl>
> diff -uprN -X /linux/dontdiff a/drivers/bluetooth/bt3c_cs.c b/drivers/bluetooth/bt3c_cs.c
> --- a/drivers/bluetooth/bt3c_cs.c 2004-08-26 22:05:15.000000000 +0200
> +++ b/drivers/bluetooth/bt3c_cs.c 2004-11-10 01:23:01.000000000 +0100
> @@ -489,13 +489,10 @@ static int bt3c_hci_ioctl(struct hci_dev
>
> static struct device *bt3c_device(void)
> {
> - static char *kobj_name = "bt3c";
> -
> static struct device dev = {
> .bus_id = "pcmcia",
> };
> - dev.kobj.k_name = kmalloc(strlen(kobj_name) + 1, GFP_KERNEL);
> - strcpy(dev.kobj.k_name, kobj_name);
> + kobject_set_name(&dev.kobj, "bt3c");
> kobject_init(&dev.kobj);
>
> return &dev;
The part for the bt3c_cs driver is fine with me and I have no problem if
Andrew picks this up and sends it to Linus for final inclusion. Once the
PCMCIA subsystem if fully integrated into the device model this will go
away anyway.
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
prev parent reply other threads:[~2004-11-10 1:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-10 0:59 [PATCH] remove explicit k_name use in atmel_cs.c, bt3c_cs.c Andries Brouwer
2004-11-10 1:15 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1100049318.25879.13.camel@pegasus \
--to=marcel@holtmann.org \
--cc=Andries.Brouwer@cwi.nl \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox