public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: ralf@linux-mips.org, davem@davemloft.net, torvalds@osdl.org
Subject: Re: [AX25]: Fix cb lookup
Date: Thu, 11 Nov 2004 14:25:30 +0000	[thread overview]
Message-ID: <1100183113.22255.19.camel@localhost.localdomain> (raw)
In-Reply-To: <200411110108.iAB18g00028445@hera.kernel.org>

On Mer, 2004-11-10 at 05:54, Linux Kernel Mailing List wrote:
> ChangeSet 1.2026.76.14, 2004/11/09 21:54:43-08:00, ralf@linux-mips.org
> 
> 	[AX25]: Fix cb lookup
> 	
> 	Ax AX.25 connection is identified only by it's source and destination,
> 	not by the device it's routed through, so fix the connection block
> 	lookup to ignore the device of a connection.  This fixes dying connections
> 	in case of an AX.25 routing flap.

At least the way some networks are run this is incorrect. You've just
killed AX.25 support for networks that do assume the same callsign on a
different
frequency is a different connection. This should at least have a sysctl
to switch the behaviour. 

The whole notion of an AX.25 routing flap is mildly amusing given that
AX.25 isnt routed but is a link layer point to point protocol with a
broadcast datagram hack attached. I know people do it just like they
"route" netbeui but the default behaviour ought to reflect the AX.25
standard document and do the link layer checks.

Alan



           reply	other threads:[~2004-11-11 15:33 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <200411110108.iAB18g00028445@hera.kernel.org>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1100183113.22255.19.camel@localhost.localdomain \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ralf@linux-mips.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox