From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Jason McMullan <jason.mcmullan@timesys.com>
Cc: Linux Kernel list <linux-kernel@vger.kernel.org>,
Jeff Garzik <jgarzik@pobox.com>,
romieu@fr.zoreil.com
Subject: Re: [PATCH] MII bus API for PHY devices
Date: Fri, 12 Nov 2004 17:15:31 +1100 [thread overview]
Message-ID: <1100240131.20512.47.camel@gaston> (raw)
In-Reply-To: <20041111224845.GA12646@jmcmullan.timesys>
On Thu, 2004-11-11 at 17:48 -0500, Jason McMullan wrote:
> Second attempt, more polish.
>
> (Though I'm leaving my macro abuse in for now!)
>
> Description: MII Bus interface
> Date: Thu, 11 Nov 2004 17:44:57 -0500
> Signed-off-by: Jason McMullan <jmcmullan@timesys.com>
> Depends:
> linux-2.6.9
Have you looked at what sungem/sungem_phy does ?
Among others, sungem has an algorithm for automatically testing fallback
forced speeds when aneg fails, which has proven useful with a variety of
PHY/hub combos, plus a "magic_aneg" bit in the PHY definition for PHYs
taht can do that themselves automatically.
Also, besides shutdown(), you probably want a suspend() callback used by
the MAC driver when the machine is entering a suspend() state (I
definitely need that with various PHYs on powermacs) along with the
various WOL parameters.
Ben.
next prev parent reply other threads:[~2004-11-12 6:16 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-11 22:48 [PATCH] MII bus API for PHY devices Jason McMullan
2004-11-11 23:54 ` Francois Romieu
2004-11-12 0:07 ` Francois Romieu
2004-11-12 6:15 ` Benjamin Herrenschmidt [this message]
2004-11-12 16:47 ` Jason McMullan
2004-11-13 1:36 ` Benjamin Herrenschmidt
-- strict thread matches above, loose matches on Subject: below --
2004-11-19 20:18 Manfred Spraul
2004-11-19 21:01 ` Andy Fleming
[not found] <069B6F33-341C-11D9-9652-000393DBC2E8@freescale.com>
2004-11-18 17:52 ` Andy Fleming
2004-11-18 19:34 ` Jason McMullan
2004-11-18 19:50 ` Andy Fleming
2004-11-18 21:00 ` Jason McMullan
2004-11-18 23:26 ` Benjamin Herrenschmidt
2004-11-19 16:41 ` Jason McMullan
2004-11-19 21:18 ` Andy Fleming
2004-11-19 22:43 ` Benjamin Herrenschmidt
2004-11-20 0:04 ` Andy Fleming
2004-11-11 19:45 Jason McMullan
2004-11-11 21:31 ` Francois Romieu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1100240131.20512.47.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=jason.mcmullan@timesys.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox