Re: [PATCH] PCI fixes for 2.6.10-rc1

Greg KH
2004-11-12T23:44:46Z

ChangeSet 1.2026.66.11, 2004/11/05 14:09:34-08:00, greg@kroah.com

PCI: remove kernel log message about drivers not calling pci_disable_device()

Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>

drivers/pci/pci-driver.c | 15 ++++++---------
1 files changed, 6 insertions(+), 9 deletions(-)

diff -Nru a/drivers/pci/pci-driver.c b/drivers/pci/pci-driver.c
--- a/drivers/pci/pci-driver.c 2004-11-12 15:13:35 -08:00
+++ b/drivers/pci/pci-driver.c 2004-11-12 15:13:35 -08:00
@@ -271,17 +271,14 @@
pci_dev->driver = NULL;
}

-#ifdef CONFIG_DEBUG_KERNEL
/*
- * If the driver decides to stop using the device, it should
- * call pci_disable_device().
+ * We would love to complain here if pci_dev->is_enabled is set, that
+ * the driver should have called pci_disable_device(), but the
+ * unfortunate fact is there are too many odd BIOS and bridge setups
+ * that don't like drivers doing that all of the time.
+ * Oh well, we can dream of sane hardware when we sleep, no matter how
+ * horrible the crap we have to deal with is when we are awake...
*/
- if (pci_dev->is_enabled) {
- dev_warn(&pci_dev->dev, "Device was removed without properly "
- "calling pci_disable_device(). This may need fixing.\n");
- /* WARN_ON(1); */
- }
-#endif /* CONFIG_DEBUG_KERNEL */

pci_dev_put(pci_dev);
return 0;