Re: [PATCH] PCI fixes for 2.6.10-rc1

Jan Dittmer
2004-11-13T10:03:52Z

Russell King wrote:
> On Fri, Nov 12, 2004 at 03:21:58PM -0800, Greg KH wrote:
>
>>ChangeSet 1.2091.1.2, 2004/11/11 16:32:25-08:00, jdittmer@ppp0.net
>>
>>[PATCH] fakephp: introduce pci_bus_add_device
>>
>>fakephp needs to add newly discovered devices to the global pci list.
>>Therefore seperate out the appropriate chunk from pci_bus_add_devices
>>to pci_bus_add_device to add a single device to sysfs, procfs
>>and the global device list.
>
>
> Why is this needed? pci_bus_add_devices() is designed to only add new
> devices to the device tree - new devices have an empty dev->global_list.
>
> Just calling pci_bus_add_devices() for the parent bus should suffice.

The device got removed from bus->devices, so I can't call that.
pci_do_scan_bus would probably the correct function to call.
But it isn't aware of already existing devices and doesn't allow
to add the hotplug slot after discovering new devices.
Well I could walk the device tree afterwards and find unbound
devices. Still pci_scan_slot would rescan and reenable all devices.
What do I overlook?

Thanks,

Jan