From: Heiko Stuebner <heiko@sntech.de>
To: John Keeping <john@metanate.com>
Cc: iommu@lists.linux-foundation.org, Joerg Roedel <joro@8bytes.org>,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
ZhengShunQian <zhengsq@rock-chips.com>
Subject: Re: [PATCH] iommu/rockchip: fix zap cache during device attach
Date: Sat, 14 May 2016 22:19:43 +0200 [thread overview]
Message-ID: <11003810.ccjcAXkzhi@phil> (raw)
In-Reply-To: <20160510155046.24515-1-john@metanate.com>
Am Dienstag, 10. Mai 2016, 16:50:46 schrieb John Keeping:
> rk_iommu_command() takes a struct rk_iommu and iterates over the slave
> MMUs, so this is doubly wrong in that we're passing in the wrong pointer
> and talking to MMUs that we shouldn't be.
>
> Fixes: cd6438c5f844 ("iommu/rockchip: Reconstruct to support multi
> slaves") Signed-off-by: John Keeping <john@metanate.com>
on a rk3288-veyron
Tested-by: Heiko Stuebner <heiko@sntech.de>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
I was wondering for a short time why this didn't spew warnings until I
realized that the iommu->bases[i] is of course a void* .
Heiko
next prev parent reply other threads:[~2016-05-14 20:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-10 15:50 [PATCH] iommu/rockchip: fix zap cache during device attach John Keeping
2016-05-14 20:19 ` Heiko Stuebner [this message]
2016-05-15 11:16 ` John Keeping
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11003810.ccjcAXkzhi@phil \
--to=heiko@sntech.de \
--cc=iommu@lists.linux-foundation.org \
--cc=john@metanate.com \
--cc=joro@8bytes.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=zhengsq@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).