From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753975AbcENUUB (ORCPT ); Sat, 14 May 2016 16:20:01 -0400 Received: from gloria.sntech.de ([95.129.55.99]:43432 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753914AbcENUUA (ORCPT ); Sat, 14 May 2016 16:20:00 -0400 From: Heiko Stuebner To: John Keeping Cc: iommu@lists.linux-foundation.org, Joerg Roedel , linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, ZhengShunQian Subject: Re: [PATCH] iommu/rockchip: fix zap cache during device attach Date: Sat, 14 May 2016 22:19:43 +0200 Message-ID: <11003810.ccjcAXkzhi@phil> User-Agent: KMail/4.14.10 (Linux/4.3.0-1-amd64; KDE/4.14.14; x86_64; ; ) In-Reply-To: <20160510155046.24515-1-john@metanate.com> References: <20160510155046.24515-1-john@metanate.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Dienstag, 10. Mai 2016, 16:50:46 schrieb John Keeping: > rk_iommu_command() takes a struct rk_iommu and iterates over the slave > MMUs, so this is doubly wrong in that we're passing in the wrong pointer > and talking to MMUs that we shouldn't be. > > Fixes: cd6438c5f844 ("iommu/rockchip: Reconstruct to support multi > slaves") Signed-off-by: John Keeping on a rk3288-veyron Tested-by: Heiko Stuebner Reviewed-by: Heiko Stuebner I was wondering for a short time why this didn't spew warnings until I realized that the iommu->bases[i] is of course a void* . Heiko