* [PATCH] x86_64: assign_irq_vector should not be marked __init
@ 2004-11-14 13:26 Alexander Nyberg
2004-11-14 21:05 ` Andi Kleen
0 siblings, 1 reply; 2+ messages in thread
From: Alexander Nyberg @ 2004-11-14 13:26 UTC (permalink / raw)
To: torvalds; +Cc: ak, linux-kernel
Hej Linus
This box crashed at startup today and I noticed that some modules will
need to have assign_irq_vector() available although it is marked as __init.
Looks like it was done for i386 in but not x86_64...
Signed off by: Alexander Nyberg <alexn@dsv.su.se>
===== arch/x86_64/kernel/io_apic.c 1.38 vs edited =====
--- 1.38/arch/x86_64/kernel/io_apic.c 2004-10-28 09:39:50 +02:00
+++ edited/arch/x86_64/kernel/io_apic.c 2004-11-14 14:03:50 +01:00
@@ -654,11 +654,7 @@
/* irq_vectors is indexed by the sum of all RTEs in all I/O APICs. */
u8 irq_vector[NR_IRQ_VECTORS] = { FIRST_DEVICE_VECTOR , 0 };
-#ifdef CONFIG_PCI_MSI
int assign_irq_vector(int irq)
-#else
-int __init assign_irq_vector(int irq)
-#endif
{
static int current_vector = FIRST_DEVICE_VECTOR, offset = 0;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] x86_64: assign_irq_vector should not be marked __init
2004-11-14 13:26 [PATCH] x86_64: assign_irq_vector should not be marked __init Alexander Nyberg
@ 2004-11-14 21:05 ` Andi Kleen
0 siblings, 0 replies; 2+ messages in thread
From: Andi Kleen @ 2004-11-14 21:05 UTC (permalink / raw)
To: Alexander Nyberg; +Cc: torvalds, ak, linux-kernel
On Sun, Nov 14, 2004 at 02:26:50PM +0100, Alexander Nyberg wrote:
> Hej Linus
>
> This box crashed at startup today and I noticed that some modules will
> need to have assign_irq_vector() available although it is marked as __init.
> Looks like it was done for i386 in but not x86_64...
Thanks added to my tree.
-Andi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-11-14 21:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-11-14 13:26 [PATCH] x86_64: assign_irq_vector should not be marked __init Alexander Nyberg
2004-11-14 21:05 ` Andi Kleen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox