From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Subject: [PATCH] sysrq and 8250 serial console 2.6.10-rc1-mm3
Date: Tue, 16 Nov 2004 14:17:33 -0500 [thread overview]
Message-ID: <1100632653.14403.2.camel@localhost.localdomain> (raw)
I don't know if anyone else caught this, but the sysrq doesn't work with
the serial console for 8250. This is a simple patch, the serial_8250.h
also calls serial_core.h before SUPPORT_SYSRQ is defined. And thus the
inlines in serial core do not support sysrq.
Here's the fix, I was even more paranoid and put the define before all
serial headers.
--- linux-2.6.10-rc1-mm3/drivers/serial/8250.c_orig 2004-11-16 14:07:08.000000000 -0500
+++ linux-2.6.10-rc1-mm3/drivers/serial/8250.c 2004-11-16 14:07:47.000000000 -0500
@@ -27,6 +27,11 @@
#include <linux/init.h>
#include <linux/console.h>
#include <linux/sysrq.h>
+
+#if defined(CONFIG_SERIAL_8250_CONSOLE) && defined(CONFIG_MAGIC_SYSRQ)
+#define SUPPORT_SYSRQ
+#endif
+
#include <linux/serial_reg.h>
#include <linux/serial.h>
#include <linux/serial_8250.h>
@@ -37,10 +42,6 @@
#include <asm/io.h>
#include <asm/irq.h>
-#if defined(CONFIG_SERIAL_8250_CONSOLE) && defined(CONFIG_MAGIC_SYSRQ)
-#define SUPPORT_SYSRQ
-#endif
-
#include <linux/serial_core.h>
#include "8250.h"
--
Steven Rostedt
Senior Engineer
Kihon Technologies
next reply other threads:[~2004-11-16 19:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-16 19:17 Steven Rostedt [this message]
2004-11-16 19:36 ` [PATCH] sysrq and 8250 serial console 2.6.10-rc1-mm3 Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1100632653.14403.2.camel@localhost.localdomain \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox