From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Andrew Morton <akpm@osdl.org>
Cc: Soeren Sonnenburg <kernel@nn7.de>,
Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: 2.6.10-rc2 pbook oops on resume
Date: Wed, 17 Nov 2004 17:09:22 +1100 [thread overview]
Message-ID: <1100671762.14626.103.camel@gaston> (raw)
In-Reply-To: <20041116214938.65601546.akpm@osdl.org>
On Tue, 2004-11-16 at 21:49 -0800, Andrew Morton wrote:
> Soeren Sonnenburg <kernel@nn7.de> wrote:
> >
> > machine comes up ok, but I see this oops in dmesg... Any ideas ?
>
> That would be due to this code in ohci_pci_resume():
>
> #ifdef CONFIG_PMAC_PBOOK
> if (_machine == _MACH_Pmac)
> enable_irq (to_pci_dev(hcd->self.controller)->irq);
> #endif
>
> enabling an already-enabled IRQ.
>
> I think Ben plays in this area?
Yes. It's not an oops tho, and is harmless for now... The pmac code used
to disable/enable irq around sleep, but that caused this problem when
David added code to unregister/re-register the irq during sleep as well
to the generic HCD stuff.
I have some pending patches, haven't had time to finish them tho... I
have a lot of sleep-related pmac update that are waiting for me to
finish getting the stuff working on the iBook G4, and it's part of that
pile... I'll let you know tomorrow.
Ben.
prev parent reply other threads:[~2004-11-17 6:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-16 11:50 2.6.10-rc2 pbook oops on resume Soeren Sonnenburg
2004-11-17 5:49 ` Andrew Morton
2004-11-17 6:09 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1100671762.14626.103.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=akpm@osdl.org \
--cc=kernel@nn7.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox