public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drivers/video/gbefb.c
@ 2004-11-17 23:58 Giuseppe Sacco
  2004-11-18  3:57 ` Andrew Morton
  0 siblings, 1 reply; 2+ messages in thread
From: Giuseppe Sacco @ 2004-11-17 23:58 UTC (permalink / raw)
  To: lkml

[-- Attachment #1: Type: text/plain, Size: 220 bytes --]

The current gbefb.c source cannot be compiled as module because of a
small typo where "option" was written instead of "options" in two
places.

Here is a small patch that fixes it. May anyone apply it?

Thanks,
Giuseppe

[-- Attachment #2: Type: text/x-patch, Size: 338 bytes --]

Index: gbefb.c
===================================================================
RCS file: /home/cvs/linux/drivers/video/gbefb.c,v
retrieving revision 1.11
diff -r1.11 gbefb.c
1121c1121
< 	char *option = NULL;
---
> 	char *options = NULL;
1123c1123
< 	if (fb_get_options("gbefb", &option))
---
> 	if (fb_get_options("gbefb", &options))

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] drivers/video/gbefb.c
  2004-11-17 23:58 [PATCH] drivers/video/gbefb.c Giuseppe Sacco
@ 2004-11-18  3:57 ` Andrew Morton
  0 siblings, 0 replies; 2+ messages in thread
From: Andrew Morton @ 2004-11-18  3:57 UTC (permalink / raw)
  To: Giuseppe Sacco; +Cc: linux-kernel

Giuseppe Sacco <giuseppe@eppesuigoccas.homedns.org> wrote:
>
> The current gbefb.c source cannot be compiled as module because of a
>  small typo where "option" was written instead of "options" in two
>  places.
> 
>  Here is a small patch that fixes it. May anyone apply it?

Yup, I can take care of that, thanks.

In future, please use `diff -u' to generate `patch -p1' form patches.  Like
this:

--- 25/drivers/video/gbefb.c
+++ 25-akpm/drivers/video/gbefb.c
@@ -1084,9 +1084,9 @@ int __init gbefb_init(void)
 	int i, ret = 0;
 
 #ifndef MODULE
-	char *option = NULL;
+	char *options = NULL;
 
-	if (fb_get_options("gbefb", &option))
+	if (fb_get_options("gbefb", &options))
 		return -ENODEV;
 	gbefb_setup(options);
 #endif
_


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2004-11-18  3:58 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-11-17 23:58 [PATCH] drivers/video/gbefb.c Giuseppe Sacco
2004-11-18  3:57 ` Andrew Morton

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox