From: John McCutchan <ttb@tentacle.dhs.org>
To: Robert Love <rml@novell.com>
Cc: Mike Waychison <Michael.Waychison@sun.com>,
Christoph Hellwig <hch@infradead.org>,
linux-kernel@vger.kernel.org
Subject: Re: [patch] inotify: use permission not vfs_permission
Date: Wed, 17 Nov 2004 19:59:44 -0500 [thread overview]
Message-ID: <1100739584.8984.8.camel@vertex> (raw)
In-Reply-To: <1100723314.28785.0.camel@betsy.boston.ximian.com>
This looks good. Thanks.
On Wed, 2004-11-17 at 15:28 -0500, Robert Love wrote:
> On Wed, 2004-11-17 at 15:25 -0500, Mike Waychison wrote:
>
> > permission() still takes 3 arguments though. I think it is safe to pass
> > NULL for the nameidata.
>
> Ugh, I compile-tested the wrong tree. Thanks.
>
> It is safe to pass NULL.
>
> Patch below.
>
> Robert Love
>
>
> Use permission() instead of generic_permission().
>
> Signed-Off-By: Robert Love <rml@novell.com>
>
> diff -u linux/drivers/char/inotify.c linux/drivers/char/inotify.c
> --- linux/drivers/char/inotify.c 2004-11-17 12:28:27.921136656 -0500
> +++ linux/drivers/char/inotify.c 2004-11-17 12:28:27.921136656 -0500
> @@ -166,7 +166,7 @@
> inode = nd.dentry->d_inode;
>
> /* you can only watch an inode if you have read permissions on it */
> - error = vfs_permission(inode, MAY_READ);
> + error = permission(inode, MAY_READ, NULL);
> if (error) {
> inode = ERR_PTR(error);
> goto release_and_out;
>
>
--
John McCutchan <ttb@tentacle.dhs.org>
next prev parent reply other threads:[~2004-11-18 1:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-17 16:57 [patch] inotify: make our sysfs files show up Robert Love
2004-11-17 18:02 ` [patch] inotify: vfs_permission was replaced Robert Love
2004-11-17 19:08 ` Christoph Hellwig
2004-11-17 19:10 ` Robert Love
2004-11-17 19:18 ` Christoph Hellwig
2004-11-17 19:17 ` Robert Love
2004-11-17 20:09 ` Mike Waychison
2004-11-17 20:17 ` [patch] inotify: use permission not vfs_permission Robert Love
2004-11-17 20:25 ` Mike Waychison
2004-11-17 20:28 ` Robert Love
2004-11-18 0:59 ` John McCutchan [this message]
2004-11-17 20:19 ` [patch] inotify: vfs_permission was replaced Al Viro
2004-11-17 20:10 ` [patch] inotify: add sysfs store support Robert Love
2004-11-18 1:00 ` John McCutchan
2004-11-18 1:24 ` Robert Love
2004-11-18 19:05 ` [patch] inotify: grab right lock Robert Love
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1100739584.8984.8.camel@vertex \
--to=ttb@tentacle.dhs.org \
--cc=Michael.Waychison@sun.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rml@novell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox