From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Adrian Bunk <bunk@stusta.de>
Cc: Ghozlane Toumi <gtoumi@laposte.net>,
Antonino Daplas <adaplas@pol.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-fbdev-devel@lists.sourceforge.net
Subject: Re: [2.6 patch] sstfb.c: make some code static
Date: Wed, 24 Nov 2004 22:49:47 +0000 [thread overview]
Message-ID: <1101336587.2571.1.camel@localhost.localdomain> (raw)
In-Reply-To: <20041121153646.GA2829@stusta.de>
On Sul, 2004-11-21 at 15:36, Adrian Bunk wrote:
> The patch below makes some needlessly global code static.
No it doesn't. It makes some functions static (which is fine) and adds
some nasty messy pointless #ifdefs. It touches no variable at all.
Please check your description texts and also don't fill the kernel with
ifdef crap. Probably the __setup stuff should be a module param new
style too.
next prev parent reply other threads:[~2004-11-27 0:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-21 15:36 [2.6 patch] sstfb.c: make some code static Adrian Bunk
2004-11-24 22:49 ` Alan Cox [this message]
2004-11-25 15:36 ` Adrian Bunk
2004-11-25 16:50 ` Alan Cox
-- strict thread matches above, loose matches on Subject: below --
2005-02-11 18:54 Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1101336587.2571.1.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=adaplas@pol.net \
--cc=bunk@stusta.de \
--cc=gtoumi@laposte.net \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).