From: Pekka Enberg <penberg@cs.helsinki.fi>
To: akpm@osdl.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] Document kfree and vfree NULL usage
Date: Sat, 27 Nov 2004 16:26:00 +0200 [thread overview]
Message-ID: <1101565560.9988.20.camel@localhost> (raw)
Hi,
This patch adds comments for kfree() and vfree() stating that both accept
NULL pointers. I audited vfree() callers and there seems to be lots of
confusion over this in the kernel.
Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
---
slab.c | 2 ++
vmalloc.c | 3 ++-
2 files changed, 4 insertions(+), 1 deletion(-)
Index: 2.6.10-rc2/mm/slab.c
===================================================================
--- 2.6.10-rc2.orig/mm/slab.c 2004-11-27 14:33:14.000000000 +0200
+++ 2.6.10-rc2/mm/slab.c 2004-11-27 16:12:54.573387384 +0200
@@ -2535,6 +2535,8 @@
* kfree - free previously allocated memory
* @objp: pointer returned by kmalloc.
*
+ * If @objp is NULL, no operation is performed.
+ *
* Don't free memory not originally allocated by kmalloc()
* or you will run into trouble.
*/
Index: 2.6.10-rc2/mm/vmalloc.c
===================================================================
--- 2.6.10-rc2.orig/mm/vmalloc.c 2004-11-27 16:13:48.026261312 +0200
+++ 2.6.10-rc2/mm/vmalloc.c 2004-11-27 16:14:04.875699808 +0200
@@ -389,7 +389,8 @@
* @addr: memory base address
*
* Free the virtually contiguous memory area starting at @addr, as
- * obtained from vmalloc(), vmalloc_32() or __vmalloc().
+ * obtained from vmalloc(), vmalloc_32() or __vmalloc(). If @addr is
+ * NULL, no operation is performed.
*
* May not be called in interrupt context.
*/
next reply other threads:[~2004-11-27 14:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-27 14:26 Pekka Enberg [this message]
2004-11-27 17:13 ` [PATCH] Document kfree and vfree NULL usage Marcel Sebek
2004-11-27 19:30 ` Pekka Enberg
2004-11-27 20:43 ` Marcel Sebek
2004-11-27 21:23 ` Phil Oester
2004-11-28 8:05 ` Pekka Enberg
2004-11-28 9:04 ` Marcel Sebek
2004-11-29 14:18 ` [Alsa-devel] " Takashi Iwai
2004-11-27 23:58 ` Tomas Carnecky
2004-11-28 0:17 ` Nick Piggin
2004-11-28 8:20 ` Pekka Enberg
2004-11-27 23:39 ` John Levon
2004-11-28 8:00 ` Pekka Enberg
-- strict thread matches above, loose matches on Subject: below --
2004-11-27 22:17 linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1101565560.9988.20.camel@localhost \
--to=penberg@cs.helsinki.fi \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox