From: Pekka Enberg <penberg@cs.helsinki.fi>
To: Marcel Sebek <sebek64@post.cz>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Document kfree and vfree NULL usage
Date: Sat, 27 Nov 2004 21:30:43 +0200 [thread overview]
Message-ID: <1101583844.9988.6.camel@localhost> (raw)
In-Reply-To: <20041127171357.GA5381@penguin.localdomain>
Hi Marcel,
On Sat, 2004-11-27 at 18:13 +0100, Marcel Sebek wrote:
> I've cleaned up sound/ directory from "if (x) {k/v}free(x);" and similar
> constructions. I'm going to to this for most of the kernel if I found
> some time.
I have patches to clean up vfree() in the kernel which I am planning to
send to the maintainers.
On Sat, 2004-11-27 at 18:13 +0100, Marcel Sebek wrote:
> static int snd_emu10k1_playback_open(snd_pcm_substream_t * substream)
> diff -urpN linux-2.6.10-rc2/sound/pci/ice1712/ak4xxx.c linux-2.6.10-rc2.changed/sound/pci/ice1712/ak4xxx.c
> --- linux-2.6.10-rc2/sound/pci/ice1712/ak4xxx.c 2004-09-13 19:45:33.000000000 +0200
> +++ linux-2.6.10-rc2.changed/sound/pci/ice1712/ak4xxx.c 2004-11-27 17:21:57.000000000 +0100
> @@ -151,8 +151,7 @@ void snd_ice1712_akm4xxx_free(ice1712_t
> return;
> for (akidx = 0; akidx < ice->akm_codecs; akidx++) {
> akm4xxx_t *ak = &ice->akm[akidx];
> - if (ak->private_value[0])
> - kfree((void *)ak->private_value[0]);
> + kfree(ak->private_value[0]);
Did you compile this? The type of ak->private_value seems to be unsigned
long so you need that cast here.
Please compile the kernel with allmodconfig to make sure you did not
break anything and then send these to the ALSA maintainers.
Pekka
next prev parent reply other threads:[~2004-11-27 19:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-27 14:26 [PATCH] Document kfree and vfree NULL usage Pekka Enberg
2004-11-27 17:13 ` Marcel Sebek
2004-11-27 19:30 ` Pekka Enberg [this message]
2004-11-27 20:43 ` Marcel Sebek
2004-11-27 21:23 ` Phil Oester
2004-11-28 8:05 ` Pekka Enberg
2004-11-28 9:04 ` Marcel Sebek
2004-11-29 14:18 ` [Alsa-devel] " Takashi Iwai
2004-11-27 23:58 ` Tomas Carnecky
2004-11-28 0:17 ` Nick Piggin
2004-11-28 8:20 ` Pekka Enberg
2004-11-27 23:39 ` John Levon
2004-11-28 8:00 ` Pekka Enberg
-- strict thread matches above, loose matches on Subject: below --
2004-11-27 22:17 linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1101583844.9988.6.camel@localhost \
--to=penberg@cs.helsinki.fi \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sebek64@post.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox