From: Dave Hansen <haveblue@us.ibm.com>
To: Gerrit Huizenga <gh@us.ibm.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>, Rik van Riel <riel@redhat.com>,
Chris Mason <mason@suse.com>,
ckrm-tech <ckrm-tech@lists.sourceforge.net>
Subject: Re: [PATCH] CKRM 1/10: Base CKRM Events
Date: Mon, 29 Nov 2004 12:36:45 -0800 [thread overview]
Message-ID: <1101760605.9548.11.camel@localhost> (raw)
In-Reply-To: <E1CYqXA-00056l-00@w-gerrit.beaverton.ibm.com>
On Mon, 2004-11-29 at 10:46, Gerrit Huizenga wrote:
> +#define CKRM_DEF_CB(EV,fct) \
> +static inline void ckrm_cb_##fct(void) \
> +{ \
> + ckrm_invoke_event_cb_chain(CKRM_EVENT_##EV,NULL); \
> +}
The sysfs code has a bunch of these, and I think it's one of the hardest
to follow and least palatable parts of working with it. It makes
finding real declarations hard, and can make debugging a pain if
something goes wrong. You get an error in ckrm_cb_FOO(), cscope or grep
for 'ckrm_cb_FOO' and scratch your head when you come up with squat.
-- Dave
next prev parent reply other threads:[~2004-11-29 20:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-29 18:46 [PATCH] CKRM 1/10: Base CKRM Events Gerrit Huizenga
2004-11-29 19:32 ` Sam Ravnborg
2004-11-29 19:40 ` Gerrit Huizenga
2004-11-29 20:36 ` Dave Hansen [this message]
2004-11-29 21:33 ` Greg KH
2005-02-24 9:32 ` Gerrit Huizenga
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1101760605.9548.11.camel@localhost \
--to=haveblue@us.ibm.com \
--cc=akpm@osdl.org \
--cc=ckrm-tech@lists.sourceforge.net \
--cc=gh@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mason@suse.com \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox