From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Ian Pratt <Ian.Pratt@cl.cam.ac.uk>
Cc: Linux Kernel list <linux-kernel@vger.kernel.org>,
Steven.Hand@cl.cam.ac.uk, Christian.Limpach@cl.cam.ac.uk,
Keir.Fraser@cl.cam.ac.uk, Andrew Morton <akpm@osdl.org>,
"David S. Miller" <davem@redhat.com>
Subject: Re: [1/7] Xen VMM #3: add ptep_establish_new to make va available
Date: Wed, 01 Dec 2004 10:27:45 +1100 [thread overview]
Message-ID: <1101857266.5174.26.camel@gaston> (raw)
In-Reply-To: <E1CZH45-0000Gk-00@mta1.cl.cam.ac.uk>
On Tue, 2004-11-30 at 23:05 +0000, Ian Pratt wrote:
> I'd appreciate a pointer to the patch.
Well, I was hoping that David would reply with one :) It wasn't ported
to all archs tho, but I did ppc & ppc64, and he did x86 & sparc iirc
> It may still be of some use to distinguish between call sites
> where it is likely that mm == current->mm to avoid adding a
> futile test in all the others.
Maybe ...
> > Is there also a need for ptep_establish and ptep_establish_new to be 2
> > different functions ?
>
> They allow different TLB invalidation behaviour. I guess it could
> be one function with an extra arg.
Not sure, my point is that we tend nowadays to have one abstraction per
call site, and I wonder if it's the right way to go ...
Ben.
next prev parent reply other threads:[~2004-11-30 23:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-30 2:06 [1/7] Xen VMM #3: add ptep_establish_new to make va available Ian Pratt
2004-11-30 2:21 ` Andrea Arcangeli
2004-11-30 22:49 ` Benjamin Herrenschmidt
2004-11-30 23:05 ` Ian Pratt
2004-11-30 23:27 ` Benjamin Herrenschmidt [this message]
2004-12-01 4:01 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1101857266.5174.26.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=Christian.Limpach@cl.cam.ac.uk \
--cc=Ian.Pratt@cl.cam.ac.uk \
--cc=Keir.Fraser@cl.cam.ac.uk \
--cc=Steven.Hand@cl.cam.ac.uk \
--cc=akpm@osdl.org \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox