[ACPI] Re: Fw: ACPI bug causes cd-rom lock-ups (2.6.10-rc2)

matthieu castet
2004-12-01T23:34:26Z

>+/*
>+ * We'd like PNP to call this routine for the
>+ * single ISA_USED value for each legacy device.
>+ * But instead it calls us with each POSSIBLE setting.
>+ * There is no ISA_POSSIBLE weight, so we simply use
>+ * the (small) PCI_USING penalty.
>+ */

Couldn't be better to change the pnp core behaviour ?

In drivers/pnp/resource.c, pnp_register_irq_resource, instead of calling
pcibios_penalize_isa_irq couldn't we call something like
pcibios_penalize_possible_isa_irq ?

The pnp implemations already use pcibios_penalize_isa_irq [1] for the
irq that are used.
So it seem it is call 2 times for the allocated resources...
Also don't we need to depenalize the irq, if we change the irq or
disable the device ?

Matthieu CASTET

[1]
$grep -r penalize */*
pnpacpi/rsparser.c:
pcibios_penalize_isa_irq(res->data.irq.interrupts[0]);
pnpacpi/rsparser.c:
pcibios_penalize_isa_irq(res->data.extended_irq.interrupts[0]);
pnpbios/rsparser.c: pcibios_penalize_isa_irq(irq);