From: Robert Love <rml@novell.com>
To: Miguel Angel Flores <maf@sombragris.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] aic7xxx large integer
Date: Sat, 04 Dec 2004 17:01:17 -0500 [thread overview]
Message-ID: <1102197677.6052.77.camel@localhost> (raw)
In-Reply-To: <41B222BE.9020205@sombragris.com>
On Sat, 2004-12-04 at 21:49 +0100, Miguel Angel Flores wrote:
> - mask_39bit = 0x7FFFFFFFFFULL;
> + mask_39bit = 0x7FFFFFFF;
I cannot believe that this is the correct solution and, if it is, the
name of the variable ought to be changed.
More likely, I suspect that the mask wants to be 39-bits, what with its
name and all.
The problem is that DMA addresses come in both 32-bit (generic) and
64-bit (high) forms. mask_39bit is a dma_addr_t so it is 64-bit if
CONFIG_HIGHMEM64G and 32-bit otherwise. Possibly, the right solution is
to make mask_39bit dma64_addr_t. Or, if the mapping needs to be
consistent, assign a different value depending on the value of
CONFIG_HIGHMEM64G.
See Documentation/DMA-*.txt for more information.
Robert Love
next prev parent reply other threads:[~2004-12-04 22:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-04 20:49 [PATCH] aic7xxx large integer Miguel Angel Flores
2004-12-04 20:59 ` Dr. David Alan Gilbert
2004-12-04 22:01 ` Robert Love [this message]
2004-12-04 23:16 ` Miguel Angel Flores
2004-12-05 1:02 ` Robert Love
2004-12-06 21:35 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1102197677.6052.77.camel@localhost \
--to=rml@novell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maf@sombragris.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox