From: Robert Love <rml@novell.com>
To: Miguel Angel Flores <maf@sombragris.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] aic7xxx large integer
Date: Sat, 04 Dec 2004 20:02:06 -0500 [thread overview]
Message-ID: <1102208526.6052.87.camel@localhost> (raw)
In-Reply-To: <41B24542.7010803@sombragris.com>
On Sun, 2004-12-05 at 00:16 +0100, Miguel Angel Flores wrote:
> I post the patch very quickly :(. The original code finally seems OK. My
> controller is not working with 39 bit addressing, although I can't find
> why the compiler warns. Maybe the length of dma_addr_t type, in the
> 2.6.9 the type of the mask_39bit variable is bus_addr_t.
The compiler warns because you are putting a 64-bit value (an unsigned
long long) in a 32-bit value (a u32).
There is definitely a problem on non-highmem compiled kernels, there is
no doubt of that. The concern was that your suggested fix is not right.
Assuming that a 39-bit value is really wanted, the type either needs to
be changed to a dma64_addr_t or the value needs to change at
compile-time to a suitable 32-bit variant when !CONFIG_HIGHMEM64G.
Without knowing what the driver is doing, I have no idea.
Robert Love
next prev parent reply other threads:[~2004-12-05 1:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-04 20:49 [PATCH] aic7xxx large integer Miguel Angel Flores
2004-12-04 20:59 ` Dr. David Alan Gilbert
2004-12-04 22:01 ` Robert Love
2004-12-04 23:16 ` Miguel Angel Flores
2004-12-05 1:02 ` Robert Love [this message]
2004-12-06 21:35 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1102208526.6052.87.camel@localhost \
--to=rml@novell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maf@sombragris.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox