From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Pavel Pisa <pisa@cmp.felk.cvut.cz>
Cc: Ingo Molnar <mingo@redhat.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@osdl.org>,
trivial@rustcorp.com.au
Subject: Re: VM86 interrupt emulation breakage and FIXes for 2.6.x kernel series
Date: Fri, 10 Dec 2004 21:05:33 +0000 [thread overview]
Message-ID: <1102712732.3264.73.camel@localhost.localdomain> (raw)
In-Reply-To: <200412091459.51583.pisa@cmp.felk.cvut.cz>
On Iau, 2004-12-09 at 13:59, Pavel Pisa wrote:
> if (vm86_irqs[intno].sig)
> send_sig(vm86_irqs[intno].sig, vm86_irqs[intno].tsk, 1);
> /* else user will poll for IRQs */
> + spin_unlock_irqrestore(&irqbits_lock, flags);
> + /* Next line would be required to handle correctly level activated
> interrupts */
> + disable_irq(intno);
> + return IRQ_HANDLED;
You can't disable_irq and return to user space - the IRQ may be shared
by a device needed to make user space progress.
The rest looks like a real bug.
next prev parent reply other threads:[~2004-12-10 22:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-09 13:59 VM86 interrupt emulation breakage and FIXes for 2.6.x kernel series Pavel Pisa
2004-12-09 16:09 ` Linus Torvalds
2004-12-10 21:05 ` Alan Cox [this message]
2004-12-10 22:55 ` Linus Torvalds
2004-12-10 23:58 ` Alan Cox
2004-12-11 1:23 ` Linus Torvalds
2004-12-11 0:57 ` Alan Cox
2004-12-11 2:30 ` Pavel Pisa
2004-12-11 4:21 ` Linus Torvalds
2004-12-11 14:19 ` Alan Cox
2004-12-11 18:45 ` Linus Torvalds
2004-12-11 18:46 ` Alan Cox
2005-04-26 8:49 ` [PATCH] Linux 2.6.x VM86 interrupt emulation fixes - the second round Pavel Pisa
2004-12-11 2:07 ` VM86 interrupt emulation breakage and FIXes for 2.6.x kernel series Pavel Pisa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1102712732.3264.73.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pisa@cmp.felk.cvut.cz \
--cc=torvalds@osdl.org \
--cc=trivial@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox