From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261937AbULKOrJ (ORCPT ); Sat, 11 Dec 2004 09:47:09 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261942AbULKOrJ (ORCPT ); Sat, 11 Dec 2004 09:47:09 -0500 Received: from stat16.steeleye.com ([209.192.50.48]:27011 "EHLO hancock.sc.steeleye.com") by vger.kernel.org with ESMTP id S261937AbULKOrF (ORCPT ); Sat, 11 Dec 2004 09:47:05 -0500 Subject: Re: [BK PATCH] SCSI -rc fixes for 2.6.10-rc3 From: James Bottomley To: "Randy.Dunlap" Cc: Jens Axboe , Andrew Morton , Linus Torvalds , SCSI Mailing List , Linux Kernel In-Reply-To: <41BA2948.4030906@osdl.org> References: <1102650988.3814.13.camel@mulgrave> <20041210201115.GD12581@suse.de> <41BA2948.4030906@osdl.org> Content-Type: text/plain Organization: SteelEye Technology, inc. Date: Sat, 11 Dec 2004 08:46:46 -0600 Message-Id: <1102776407.5688.4.camel@mulgrave> Mime-Version: 1.0 X-Mailer: Evolution 2.0.2 (2.0.2-3) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2004-12-10 at 14:55 -0800, Randy.Dunlap wrote: > I have a drive, but I'm not near a highmem machine atm. > I can test it next week if no one else does so. So would you be amenable to fixing it properly? It looks like what needs to happen is that it needs to accept its commands into the scsi_pointer with page and offset (scsi_pointer doesn't have these fields, but you could probably cast in ptr and dma_handle). Then do a kmap/kunmap around imm_in() and imm_out() when it's operating on SCp.ptr. James