From: Rusty Russell <rusty@rustcorp.com.au>
To: Andries Brouwer <Andries.Brouwer@cwi.nl>
Cc: Harald Welte <laforge@netfilter.org>,
Andries Brouwer <aebr@win.tue.nl>,
Patrick McHardy <kaber@trash.net>, Andrew Morton <akpm@osdl.org>,
Linus Torvalds <torvalds@osdl.org>,
Netfilter Core Team <coreteam@netfilter.org>,
lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [netfilter-core] [PATCH] no __initdata in netfilter?
Date: Wed, 15 Dec 2004 15:21:04 +1100 [thread overview]
Message-ID: <1103084464.4696.6.camel@localhost.localdomain> (raw)
In-Reply-To: <20041214183911.GA15606@apps.cwi.nl>
On Tue, 2004-12-14 at 19:39 +0100, Andries Brouwer wrote:
> I think that argument is valid only when satisfying the static tool
> is especially cumbersome or inefficient, requires ugly code, etc.
> In most cases a trivial rewrite will suffice, and the result is cleaner
> code, easier to maintain, fewer bugs.
Exactly, and Harald just handed you that trivial rewrite. It's clearer
than before, and shouldn't trip your static checker.
Your patch just ripped out the __initdata, making it suboptimal
*without* making the code clearer.
Rusty.
--
A bad analogy is like a leaky screwdriver -- Richard Braakman
prev parent reply other threads:[~2004-12-15 4:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-14 1:37 [PATCH] no __initdata in netfilter? Andries Brouwer
2004-11-14 7:56 ` [netfilter-core] " Patrick McHardy
2004-11-14 11:26 ` Andries Brouwer
2004-12-14 13:00 ` Harald Welte
2004-12-14 15:52 ` Linus Torvalds
2004-12-14 18:39 ` Andries Brouwer
2004-12-14 18:51 ` Harald Welte
2004-12-15 4:21 ` Rusty Russell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1103084464.4696.6.camel@localhost.localdomain \
--to=rusty@rustcorp.com.au \
--cc=Andries.Brouwer@cwi.nl \
--cc=aebr@win.tue.nl \
--cc=akpm@osdl.org \
--cc=coreteam@netfilter.org \
--cc=kaber@trash.net \
--cc=laforge@netfilter.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox