From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: James Nelson <james4765@verizon.net>
Cc: kernel-janitors@lists.osdl.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
akpm@osdl.org
Subject: Re: [PATCH] pcxx: replace cli()/sti() with spin_lock_irqsave()/spin_unlock_irqrestore()
Date: Mon, 20 Dec 2004 20:23:50 +0000 [thread overview]
Message-ID: <1103574222.31479.12.camel@localhost.localdomain> (raw)
In-Reply-To: <1103554747.30268.24.camel@localhost.localdomain>
On Llu, 2004-12-20 at 14:59, Alan Cox wrote:
> On Gwe, 2004-12-17 at 22:34, James Nelson wrote:
> > - save_flags(flags);
> > - cli();
> > + spin_lock_irqsave(&pcxx_lock, flags);
> > del_timer_sync(&pcxx_timer);
>
> Not safe if the lock is grabbed by the timer between the lock and the
> irqsave as it will spin on another cpu and the timer delete will never
> finish.
Error between brain and keyboard
Between the lock and the timer_delete of course
next prev parent reply other threads:[~2004-12-20 21:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-17 22:34 [PATCH] pcxx: replace cli()/sti() with spin_lock_irqsave()/spin_unlock_irqrestore() James Nelson
2004-12-20 14:59 ` Alan Cox
2004-12-20 17:27 ` [KJ] " Matthew Wilcox
2004-12-20 20:23 ` Alan Cox [this message]
2004-12-20 21:51 ` Jim Nelson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1103574222.31479.12.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@osdl.org \
--cc=james4765@verizon.net \
--cc=kernel-janitors@lists.osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox