From: Lee Revell <rlrevell@joe-job.com>
To: David Brownell <david-b@pacbell.net>
Cc: Greg KH <greg@kroah.com>, Lukas Hejtmanek <xhejtman@mail.muni.cz>,
linux-kernel@vger.kernel.org,
linux-usb-devel@lists.sourceforge.net
Subject: Re: Scheduling while atomic (2.6.10-rc3-bk13)
Date: Mon, 20 Dec 2004 15:57:43 -0500 [thread overview]
Message-ID: <1103576264.1252.87.camel@krustophenia.net> (raw)
In-Reply-To: <200412201152.16329.david-b@pacbell.net>
On Mon, 2004-12-20 at 11:52 -0800, David Brownell wrote:
> On Monday 20 December 2004 10:48 am, Greg KH wrote:
>
> >
> > David, it looks like you grab a spinlock, and then call msleep(20);
> > which causes this warning.
> >
> > Care to fix it?
>
> How bizarre ... I must have been tested that without spinlock
> debugging, for some reason. Grr. I usually leave that on,
> just to prevent stuff like this.
>
> Here's a quick'n'dirty patch, msleep --> mdelay. I'd rather
> not mdelay for that long, but this late in 2.6.10 it's safer.
> (And this is also what OHCI does in that same code path.)
Ugh. 20ms is WAY too long to hold a spinlock. That's guaranteed to
cause audio skips. Isn't there another way?
If OHCI calls mdelay(20) while holding a spinlock that needs to be
fixed.
Lee
next prev parent reply other threads:[~2004-12-20 20:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-19 23:10 Scheduling while atomic (2.6.10-rc3-bk13) Lukas Hejtmanek
2004-12-20 18:48 ` Greg KH
2004-12-20 19:52 ` David Brownell
2004-12-20 20:57 ` Lee Revell [this message]
2004-12-20 21:31 ` [linux-usb-devel] " David Brownell
2004-12-20 21:32 ` Lee Revell
2004-12-21 19:20 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1103576264.1252.87.camel@krustophenia.net \
--to=rlrevell@joe-job.com \
--cc=david-b@pacbell.net \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
--cc=xhejtman@mail.muni.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox