public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Jesse Barnes <jbarnes@engr.sgi.com>
Cc: linux-pci@atrey.karlin.mff.cuni.cz, Greg KH <greg@kroah.com>,
	Linux Kernel list <linux-kernel@vger.kernel.org>,
	Bjorn Helgaas <bjorn.helgaas@hp.com>,
	willy@debian.org
Subject: Re: [PATCH] add PCI API to sysfs
Date: Tue, 21 Dec 2004 08:12:01 +0100	[thread overview]
Message-ID: <1103613121.21771.28.camel@gaston> (raw)
In-Reply-To: <200412201501.12575.jbarnes@engr.sgi.com>


> Yeah, I mentioned that in "things to do" at the bottom, but I'm really looking 
> for an "ack, this is a sane way to go" before I sink much more time into it.

Overall, I like it, though I yet have to scrub the details. As far as
the legacy space is concerned, I'd be as "generic" as possible and thus
provide the legacy-files on a per-bus basis. That is each pci bus could
expose those even if it's not a host bridge. It's an arch matter to
actually implement them, and by default, I suppose archs would just
treat all busses of a domain the same, but it leaves us with the
necessary flexibility for setups with bridges that can remap the legacy
space or that kind of thing.

Great work !

Ben.



  reply	other threads:[~2004-12-21  7:12 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-20 22:50 [PATCH] add PCI API to sysfs Jesse Barnes
2004-12-20 22:58 ` Greg KH
2004-12-20 23:01   ` Jesse Barnes
2004-12-21  7:12     ` Benjamin Herrenschmidt [this message]
2004-12-21 12:31       ` Matthew Wilcox
2004-12-21 16:13         ` Benjamin Herrenschmidt
2004-12-21 17:05     ` Greg KH
2004-12-21 17:20       ` Jesse Barnes
2004-12-21  7:10   ` Benjamin Herrenschmidt
2004-12-21 16:22     ` Jesse Barnes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1103613121.21771.28.camel@gaston \
    --to=benh@kernel.crashing.org \
    --cc=bjorn.helgaas@hp.com \
    --cc=greg@kroah.com \
    --cc=jbarnes@engr.sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@atrey.karlin.mff.cuni.cz \
    --cc=willy@debian.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox