public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: David Brownell <david-b@pacbell.net>,
	Linux Kernel list <linux-kernel@vger.kernel.org>,
	Greg KH <greg@kroah.com>, Linus Torvalds <torvalds@osdl.org>
Subject: Re: [PATCH] USB: fix Scheduling while atomic warning when resuming.
Date: Wed, 22 Dec 2004 12:59:28 +0100	[thread overview]
Message-ID: <1103716768.28670.61.camel@gaston> (raw)
In-Reply-To: <41C905C0.9000705@pobox.com>


> If the PCI layer is calling the resume method for a PCI device while 
> simultaneously calling the suspend method, that's a PCI layer problem. 
> Similarly, If the USB layer is calling into your driver while you are 
> resuming, something is broken and it ain't your locking.

Actually, the later isn't broken, something may well call into the
higher level USB drivers while resuming, but indeed, those shouldn't
send any URB down the stack when the bus is suspended, and the EHCI
driver should drop incoming URBs as well until fully resumed.

I think the lock here is only needed to protect the HCD state
transitions David, no ? All we need is make sure that we don't let
things get queued (or call into EHCI code path that will end up
touch the HW) while suspended.

Ben.



  reply	other threads:[~2004-12-22 12:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200412220103.iBM13wS0002158@hera.kernel.org>
2004-12-22  3:48 ` [PATCH] USB: fix Scheduling while atomic warning when resuming Jeff Garzik
2004-12-22  4:22   ` David Brownell
2004-12-22  4:46     ` Jeff Garzik
2004-12-22  4:59       ` David Brownell
2004-12-22  5:27         ` Jeff Garzik
2004-12-22 11:59           ` Benjamin Herrenschmidt [this message]
2004-12-22 16:16             ` David Brownell
2004-12-22 16:35               ` Benjamin Herrenschmidt
2004-12-22 16:14           ` David Brownell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1103716768.28670.61.camel@gaston \
    --to=benh@kernel.crashing.org \
    --cc=david-b@pacbell.net \
    --cc=greg@kroah.com \
    --cc=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox