From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Adrian Bunk <bunk@stusta.de>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
pazke@donpac.ru, linux-visws-devel@lists.sf.net
Subject: Re: [2.6 patch] i386: reboot.c cleanups
Date: Mon, 27 Dec 2004 10:19:55 -0600 [thread overview]
Message-ID: <1104164395.5295.24.camel@mulgrave> (raw)
In-Reply-To: <20041206004127.GH2953@stusta.de>
On Mon, 2004-12-06 at 01:41 +0100, Adrian Bunk wrote:
> The partch below includes the following changes:
> - arch/i386/kernel/reboot.c: make reboot_thru_bios static
> - arch/i386/mach-visws/reboot.c: remove the unused reboot_thru_bios and
> reboot_smp
> - arch/i386/mach-voyager/voyager_basic.c: remove the unused reboot_thru_bios
> - arch/i386/mach-voyager/voyager_smp.c: remove the unused reboot_smp
The description and the patch below don't match. Do you have the
correct patch?
James
> --- linux-2.6.10-rc2-mm4-full/arch/i386/kernel/process.c.old 2004-12-06 01:25:27.000000000 +0100
> +++ linux-2.6.10-rc2-mm4-full/arch/i386/kernel/process.c 2004-12-06 01:25:38.000000000 +0100
> @@ -60,7 +60,7 @@
>
> asmlinkage void ret_from_fork(void) __asm__("ret_from_fork");
>
> -int hlt_counter;
> +static int hlt_counter;
>
> unsigned long boot_option_idle_override = 0;
> EXPORT_SYMBOL(boot_option_idle_override);
> --- linux-2.6.10-rc2-mm4-full/arch/parisc/kernel/process.c.old 2004-12-06 01:25:55.000000000 +0100
> +++ linux-2.6.10-rc2-mm4-full/arch/parisc/kernel/process.c 2004-12-06 01:26:01.000000000 +0100
> @@ -54,7 +54,7 @@
> #include <asm/uaccess.h>
> #include <asm/unwind.h>
>
> -int hlt_counter;
> +static int hlt_counter;
>
> /*
> * Power off function, if any
> --- linux-2.6.10-rc2-mm4-full/arch/x86_64/kernel/process.c.old 2004-12-06 01:26:17.000000000 +0100
> +++ linux-2.6.10-rc2-mm4-full/arch/x86_64/kernel/process.c 2004-12-06 01:26:28.000000000 +0100
> @@ -53,7 +53,7 @@
>
> unsigned long kernel_thread_flags = CLONE_VM | CLONE_UNTRACED;
>
> -atomic_t hlt_counter = ATOMIC_INIT(0);
> +static atomic_t hlt_counter = ATOMIC_INIT(0);
>
> unsigned long boot_option_idle_override = 0;
> EXPORT_SYMBOL(boot_option_idle_override);
next prev parent reply other threads:[~2004-12-27 16:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-06 0:41 [2.6 patch] i386: reboot.c cleanups Adrian Bunk
2004-12-06 12:23 ` Andrey Panin
2004-12-06 13:15 ` Adrian Bunk
2004-12-27 16:19 ` James Bottomley [this message]
2004-12-27 16:29 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1104164395.5295.24.camel@mulgrave \
--to=james.bottomley@hansenpartnership.com \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-visws-devel@lists.sf.net \
--cc=pazke@donpac.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox