Re: __iounmap: bad address c00f0000 (Re: 2.6.10-bk5)

[Len Brown <len.brown@intel.com>]

On Mon, 2005-01-03 at 12:24, Len Brown wrote:
> On Sun, 2005-01-02 at 19:14, Michael Geithe wrote:
> 
> > DMI 2.3 present.
> > __iounmap: bad address c00f0000
> > ACPI: RSDP (v000 AMI                                   ) @ 0x000fa380
> 
> Not and ACPI issue:-)
> 
> Looks like the warning is provoked by Al Viro's update to dmi_iterate().
> Perhaps there is a conflict between dmi_table()'s bt_iounmap(),
> and dmi_iterate()'s new iounmap() on the same address?
> 
> -Len
> 


Try this.

Suggested-by: Al Viro
Signed-off-by: Len Brown <len.brown@intel.com>


===== arch/i386/kernel/dmi_scan.c 1.74 vs edited =====
--- 1.74/arch/i386/kernel/dmi_scan.c	2004-12-28 14:07:48 -05:00
+++ edited/arch/i386/kernel/dmi_scan.c	2005-01-03 12:46:33 -05:00
@@ -126,12 +126,12 @@
 			dmi_printk((KERN_INFO "DMI table at 0x%08X.\n",
 				base));
 			if(dmi_table(base,len, num, decode)==0) {
-				iounmap(p);
+				/* too early to call iounmap(p); */
 				return 0;
 			}
 		}
 	}
-	iounmap(p);
+	/* too early to call iounmap(p); */
 	return -1;
 }