From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
torvalds@osdl.org
Subject: Re: [ide] clean up error path in do_ide_setup_pci_device()
Date: Tue, 04 Jan 2005 22:02:46 +0000 [thread overview]
Message-ID: <1104854560.17176.5.camel@localhost.localdomain> (raw)
In-Reply-To: <20050104001454.GA7655@electric-eye.fr.zoreil.com>
On Maw, 2005-01-04 at 00:14, Francois Romieu wrote:
> /me looks at the comments in drivers/ide/pci/cs5520.c
>
> Is it worth the pain to remember if ide_setup_pci_device() did enable a
> specific bar or not in order to balance it more accurately ?
I'm not sure that tells you enough about the device to know how to
disable it or if it is safe to disable. It might be better to just check
if the device is currently enabled, if the enable bits were off then you
know you can disable it again.
next prev parent reply other threads:[~2005-01-04 23:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200412310343.iBV3hqvd015595@hera.kernel.org>
2005-01-03 18:42 ` [ide] clean up error path in do_ide_setup_pci_device() Alan Cox
2005-01-03 22:22 ` Bartlomiej Zolnierkiewicz
2005-01-03 21:44 ` Alan Cox
2005-01-04 0:14 ` Francois Romieu
2005-01-04 22:02 ` Alan Cox [this message]
2005-01-07 2:20 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1104854560.17176.5.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=bzolnier@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox