From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Simon Kirby <sim@netnation.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [2.6.10-bk7] Oops: ide_dma_timeout_retry
Date: Thu, 06 Jan 2005 16:30:14 +0000 [thread overview]
Message-ID: <1105023683.24896.213.camel@localhost.localdomain> (raw)
In-Reply-To: <20050105233359.GA2327@netnation.com>
On Mer, 2005-01-05 at 23:33, Simon Kirby wrote:
> I added the usual test for NULL, printk, goto out, and the machine
> continues without visibly exploding when this case occurs. Is the
> correct fix or is it expected that rq should never be NULL?
The initial UncorrectableError is the drive erroring the request due to
real failure of the drive to get the data. There are some races in the
base code when that occurs
rq should never be NULL at that point because after all there has to be
a request which has timed out. If the timeout isn't being cleared on the
error path that would make sense of the trace or if the timeout occurred
at the same time as the error completed it would have raced.
It could also be due to the fact base 2.6.10 will corrupt requests on
errors sometimes (which SGI now fixed)
Alan
next prev parent reply other threads:[~2005-01-06 17:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-05 23:33 [2.6.10-bk7] Oops: ide_dma_timeout_retry Simon Kirby
2005-01-06 16:30 ` Alan Cox [this message]
2005-01-06 19:23 ` Simon Kirby
2005-01-06 20:18 ` Alan Cox
2005-01-06 22:18 ` Simon Kirby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1105023683.24896.213.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=sim@netnation.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox