From: James Bottomley <James.Bottomley@SteelEye.com>
To: mike.miller@hp.com
Cc: Andrew Morton <akpm@osdl.org>, Jens Axboe <axboe@suse.de>,
Linux Kernel <linux-kernel@vger.kernel.org>,
SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH 2.6] cciss typo fix
Date: Fri, 07 Jan 2005 18:19:28 -0500 [thread overview]
Message-ID: <1105139968.4151.26.camel@mulgrave> (raw)
In-Reply-To: <20050107230103.GB26037@beardog.cca.cpqcorp.net>
On Fri, 2005-01-07 at 17:01 -0600, mike.miller@hp.com wrote:
> - *total_size = be32_to_cpu(*((__be32 *) &buf->total_size[0]))+1;
> - *block_size = be32_to_cpu(*((__be32 *) &buf->block_size[0]));
> + *total_size = be32_to_cpu(*((__u32 *) &buf->total_size[0]))+1;
> + *block_size = be32_to_cpu(*((__u32 *) &buf->block_size[0]));
I don't think that's a typo. It was introduced by this patch:
ChangeSet 1.1988.24.79 2004/10/06 07:55:02 viro@www.linux.org.uk
[PATCH] cciss endianness and iomem annotations
The idea being that BE and LE numbers should be annotated differently,
so the __be32 annotations look correct to me. I think sparse will warn
if you make this change.
James
next prev parent reply other threads:[~2005-01-08 0:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-07 23:01 [PATCH 2.6] cciss typo fix mike.miller
2005-01-07 23:19 ` James Bottomley [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-01-07 23:24 Miller, Mike (OS Dev)
2005-01-07 23:32 ` James Bottomley
2005-01-08 8:41 ` Jens Axboe
2005-01-07 23:34 Miller, Mike (OS Dev)
2005-01-10 15:45 Miller, Mike (OS Dev)
2005-01-10 15:50 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1105139968.4151.26.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=akpm@osdl.org \
--cc=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mike.miller@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox