Re: [PATCH] USB and Driver Core patches for 2.6.10

Greg KH
2005-01-08T08:29:25Z

ChangeSet 1.1938.446.30, 2004/12/17 11:41:02-08:00, mdharm-usb@one-eyed-alien.net

[PATCH] USB Storage: Increase Genesys delay

This is patch as436 from Alan Stern.

This patch increases the delay used for Genesys devices about 10%. At
least one user reports that this created a significant improvement in
operation.

Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Matthew Dharm <mdharm-usb@one-eyed-alien.net>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>

drivers/usb/storage/transport.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)

diff -Nru a/drivers/usb/storage/transport.c b/drivers/usb/storage/transport.c
--- a/drivers/usb/storage/transport.c 2005-01-07 15:46:51 -08:00
+++ b/drivers/usb/storage/transport.c 2005-01-07 15:46:51 -08:00
@@ -992,9 +992,10 @@
/* send/receive data payload, if there is any */

/* Genesys Logic interface chips need a 100us delay between the
- * command phase and the data phase */
+ * command phase and the data phase. Some devices need a little
+ * more than that, probably because of clock rate inaccuracies. */
if (us->pusb_dev->descriptor.idVendor == USB_VENDOR_ID_GENESYS)
- udelay(100);
+ udelay(110);

if (transfer_length) {
unsigned int pipe = srb->sc_data_direction == DMA_FROM_DEVICE ?