Re: [PATCH] USB and Driver Core patches for 2.6.10

Greg KH
2005-01-08T07:27:02Z

ChangeSet 1.1938.439.55, 2005/01/07 09:07:22-08:00, david-b@pacbell.net

[PATCH] USB: ohci diagnostic tweak

This changes the OHCI "USB HC TakeOver failed" message to be a bit
more informative, by fingering the root cause: a BIOS/SMM bug.

That way they're more likely to either bug the board vendor, or find
workarounds (like tweaking the BIOS setup, or the ohci_hcd no_handshake
parameter) before giving up or (wrongly) reporting a Linux bug.

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>

drivers/usb/host/ohci-hcd.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletion(-)

diff -Nru a/drivers/usb/host/ohci-hcd.c b/drivers/usb/host/ohci-hcd.c
--- a/drivers/usb/host/ohci-hcd.c 2005-01-07 15:35:13 -08:00
+++ b/drivers/usb/host/ohci-hcd.c 2005-01-07 15:35:13 -08:00
@@ -441,7 +441,8 @@
while (ohci_readl (ohci, &ohci->regs->control) & OHCI_CTRL_IR) {
msleep (10);
if (--temp == 0) {
- ohci_err (ohci, "USB HC TakeOver failed!\n");
+ ohci_err (ohci, "USB HC takeover failed!"
+ " (BIOS/SMM bug)\n");
return -EBUSY;
}
}