Re: [PATCH] USB and Driver Core patches for 2.6.10

Greg KH
2005-01-08T22:42:59Z

On Sat, Jan 08, 2005 at 12:08:58PM +0000, Christoph Hellwig wrote:
> On Fri, Jan 07, 2005 at 09:47:43PM -0800, Greg KH wrote:
> > ChangeSet 1.1938.444.33, 2004/12/22 13:50:21-08:00, davej@redhat.com
> >
> > [PATCH] driver core: Fix up vesafb failure probing.
> >
> > bus.c file invokes a probe callback for most devices in a list, then checks
> > for -ENODEV return ("no such device"), if so it remains silent. However, some
> > drivers (including vesafb.c) may return -ENXIO ("no such device or address"),
> > which is indeed error -6.
> >
> > I shut up the warning with the attached patch, that basically ignores
> > both -ENODEV and -ENXIO.
>
> NAK. We shouldn't have two return codes indicating the same error (or
> actually non-error in this case). Let's fix the drivers instead.

Ok, David, care to send a patch to do so?

thanks,

greg k-h