Re: [PATCH] USB and Driver Core patches for 2.6.10

Greg KH
2005-01-08T10:43:42Z

ChangeSet 1.1938.444.17, 2004/12/21 10:01:15-08:00, greg@kroah.com

USB: explicitly mark the endianness of some visor data fields.

Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>

drivers/usb/serial/visor.c | 4 +---
drivers/usb/serial/visor.h | 6 +++---
2 files changed, 4 insertions(+), 6 deletions(-)

diff -Nru a/drivers/usb/serial/visor.c b/drivers/usb/serial/visor.c
--- a/drivers/usb/serial/visor.c 2005-01-07 15:41:55 -08:00
+++ b/drivers/usb/serial/visor.c 2005-01-07 15:41:55 -08:00
@@ -734,9 +734,7 @@
if (retval == sizeof(*connection_info)) {
connection_info = (struct visor_connection_info *)transfer_buffer;

- le16_to_cpus(&connection_info->num_ports);
- num_ports = connection_info->num_ports;
-
+ num_ports = le16_to_cpu(connection_info->num_ports);
for (i = 0; i < num_ports; ++i) {
switch (connection_info->connections[i].port_function_id) {
case VISOR_FUNCTION_GENERIC:
diff -Nru a/drivers/usb/serial/visor.h b/drivers/usb/serial/visor.h
--- a/drivers/usb/serial/visor.h 2005-01-07 15:41:55 -08:00
+++ b/drivers/usb/serial/visor.h 2005-01-07 15:41:55 -08:00
@@ -89,7 +89,7 @@
* VISOR_GET_CONNECTION_INFORMATION returns data in the following format
****************************************************************************/
struct visor_connection_info {
- __u16 num_ports;
+ __le16 num_ports;
struct {
__u8 port_function_id;
__u8 port;
@@ -135,12 +135,12 @@
struct palm_ext_connection_info {
__u8 num_ports;
__u8 endpoint_numbers_different;
- __u16 reserved1;
+ __le16 reserved1;
struct {
__u32 port_function_id;
__u8 port;
__u8 end_point_info;
- __u16 reserved;
+ __le16 reserved;
} connections[2];
};