From: James Bottomley <James.Bottomley@SteelEye.com>
To: Andrew Morton <akpm@osdl.org>, Linus Torvalds <torvalds@osdl.org>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH] generic irq code missing export of probe_irq_mask()
Date: Thu, 13 Jan 2005 17:22:37 -0600 [thread overview]
Message-ID: <1105658558.5630.16.camel@mulgrave> (raw)
Matthew Wilcox just converted parisc over to doing the generic irq code
and we ran across the symbol probe_irq_mask being undefined (and thus
preventing yenta_socket from loading).
It looks like the EXPORT_SYMBOL() was accidentally missed from
kernel/irq/autoprobe.c and no-one noticed on x86 because it's still in
i386_ksyms.c
This patch corrects the problem so that the generic irq code now works
completely on parisc.
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
--
James
Index: linux-2.6/arch/i386/kernel/i386_ksyms.c
===================================================================
RCS file: /var/cvs/linux-2.6/arch/i386/kernel/i386_ksyms.c,v
retrieving revision 1.11
diff -u -r1.11 i386_ksyms.c
--- linux-2.6/arch/i386/kernel/i386_ksyms.c 29 Nov 2004 19:55:27 -0000 1.11
+++ linux-2.6/arch/i386/kernel/i386_ksyms.c 13 Jan 2005 23:16:41 -0000
@@ -75,7 +75,6 @@
EXPORT_SYMBOL(__ioremap);
EXPORT_SYMBOL(ioremap_nocache);
EXPORT_SYMBOL(iounmap);
-EXPORT_SYMBOL(probe_irq_mask);
EXPORT_SYMBOL(kernel_thread);
EXPORT_SYMBOL(pm_idle);
EXPORT_SYMBOL(pm_power_off);
Index: linux-2.6/kernel/irq/autoprobe.c
===================================================================
RCS file: /var/cvs/linux-2.6/kernel/irq/autoprobe.c,v
retrieving revision 1.2
diff -u -r1.2 autoprobe.c
--- linux-2.6/kernel/irq/autoprobe.c 21 Oct 2004 19:00:13 -0000 1.2
+++ linux-2.6/kernel/irq/autoprobe.c 13 Jan 2005 23:17:10 -0000
@@ -137,6 +137,7 @@
return mask & val;
}
+EXPORT_SYMBOL(probe_irq_mask);
/**
* probe_irq_off - end an interrupt autodetect
reply other threads:[~2005-01-13 23:29 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1105658558.5630.16.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox