From: Rusty Russell <rusty@rustcorp.com.au>
To: Andi Kleen <ak@suse.de>
Cc: Andrew Morton <akpm@osdl.org>,
manpreet@fabric7.com,
lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>,
discuss@x86-64.org
Subject: Re: [PATCH] i386/x86-64: Fix timer SMP bootup race
Date: Sun, 16 Jan 2005 15:20:47 +1100 [thread overview]
Message-ID: <1105849247.5711.4.camel@localhost.localdomain> (raw)
In-Reply-To: <20050115075946.GA28981@wotan.suse.de>
On Sat, 2005-01-15 at 08:59 +0100, Andi Kleen wrote:
> I think my patch is better. It at least keeps all the
> baggage out of the normal run paths. Doing this check at each timer interrupt
> doesn't make much sense.
It doesn't penalize the architectures which do the right thing already.
If this weren't i386 we were talking about...
But adding a bizarro "pre-prepare" notifier verged on nonsensical 8(. I
prefer an explicit "init_timers_early()" call as a workaround; I'll code
that up and test tomorrow, when I'm back in the office with an SMP box
to test.
I'm also not clear on why we need to enable interrupts around
calibrate_delay() on secondary processors, but I'll try that too and
find out 8)
Thanks,
Rusty.
--
A bad analogy is like a leaky screwdriver -- Richard Braakman
next prev parent reply other threads:[~2005-01-16 5:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-15 4:09 [PATCH] i386/x86-64: Fix timer SMP bootup race Andi Kleen
2005-01-15 5:09 ` Rusty Russell
2005-01-15 5:23 ` Andi Kleen
2005-01-15 7:34 ` Rusty Russell
2005-01-15 7:40 ` Andrew Morton
2005-01-15 7:59 ` Andi Kleen
2005-01-16 4:20 ` Rusty Russell [this message]
2005-01-16 5:34 ` Andi Kleen
2005-01-16 6:42 ` Rusty Russell
2005-01-15 6:28 ` Andrew Morton
2005-01-15 6:43 ` Andi Kleen
2005-01-15 6:54 ` Andrew Morton
2005-01-15 7:18 ` Andi Kleen
2005-01-17 2:34 ` Rusty Russell
2005-01-17 5:43 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1105849247.5711.4.camel@localhost.localdomain \
--to=rusty@rustcorp.com.au \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=discuss@x86-64.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manpreet@fabric7.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox