public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Tony Lindgren <tony@atomide.com>
Cc: Pavel Machek <pavel@ucw.cz>, George Anzinger <george@mvista.com>,
	john stultz <johnstul@us.ibm.com>,
	Andrea Arcangeli <andrea@suse.de>,
	Zwane Mwaikambo <zwane@arm.linux.org.uk>,
	Con Kolivas <kernel@kolivas.org>,
	Martin Schwidefsky <schwidefsky@de.ibm.com>,
	Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] dynamic tick patch
Date: Wed, 19 Jan 2005 18:08:52 +1100	[thread overview]
Message-ID: <1106118532.5295.3.camel@gaston> (raw)
In-Reply-To: <20050119063713.GB26932@atomide.com>

On Tue, 2005-01-18 at 22:37 -0800, Tony Lindgren wrote:
> * Benjamin Herrenschmidt <benh@kernel.crashing.org> [050118 21:29]:
> > Hrm... reading more of the patch & Martin's previous work, I'm not sure
> > I like the idea too much in the end... The main problem is that you are
> > just "replaying" the ticks afterward, which I see as a problem for
> > things like sched_clock() which returns the real current time, no ?
> 
> Well so far I haven't found problems with time. Since sched_clock()
> returns the hw time, how does it cause a problem? Do you have some
> example in mind? Maybe there's something I haven't even considered
> yet.
> 
> > I'll toy a bit with my own implementation directly using Martin's work
> > and see what kind of improvement I really get on ppc laptops.
> 
> I'd be interested in what you come up with :)

Well, I did a very simple implementation entirely local to
arch/ppc/kernel, that basically calls timer_interrupt on every do_IRQ, I
don't change timer_interrupt (our implementation already knows how to
"catch up" already if missed ticks and knows how to deal beeing called
to early as well). Then, when going to idle loop, I "override" the
decrementer interrupt setting to be further in the future if
next_timer_interrupt() returns more than 1.

Strangely, I got not measurable improvement on power consumption despite
putting the CPU longer into NAP mode. Note that this may be very
different with earlier (G3 notably) CPUs, since G3 users repeately
reported me havign a significant loss in battery life with HZ=1000

Later, I'll do some stats to check how long I really slept, and see if
it's worth, when I predict a long sleep, flushing the cache and going
into a deeper PM mode where cache coherency is disabled too.

Ben.



  reply	other threads:[~2005-01-19  7:09 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-19  0:05 [PATCH] dynamic tick patch Tony Lindgren
2005-01-19  0:22 ` Lee Revell
2005-01-19  1:04   ` Tony Lindgren
2005-01-19  4:21 ` Benjamin Herrenschmidt
2005-01-19  5:07   ` Tony Lindgren
2005-01-19  5:21     ` Tony Lindgren
2005-01-19  5:44       ` Benjamin Herrenschmidt
2005-01-19  6:26         ` Tony Lindgren
2005-01-19  9:45           ` Pavel Machek
2005-01-19  5:28     ` Benjamin Herrenschmidt
2005-01-19  6:37       ` Tony Lindgren
2005-01-19  7:08         ` Benjamin Herrenschmidt [this message]
2005-01-19  7:31           ` Tony Lindgren
2005-01-19 14:11       ` Stephen Frost
2005-01-19 17:17         ` Tony Lindgren
     [not found]         ` <OFDC470564.D4624EB3-ON41256F8E.00512848-41256F8E.005428CC@de.ibm.com>
2005-01-19 17:37           ` Tony Lindgren
2005-01-19  9:43 ` Pavel Machek
2005-01-19 17:13   ` Tony Lindgren
2005-01-19 17:48     ` Andrea Arcangeli
2005-01-19 18:19       ` Tony Lindgren
2005-01-19 19:12         ` Andrea Arcangeli
2005-01-19 19:17           ` Tony Lindgren
2005-01-19 19:34             ` Tony Lindgren
2005-01-19 22:42               ` Andrea Arcangeli
2005-01-19 22:59       ` George Anzinger
2005-01-19 23:17         ` Tony Lindgren
2005-01-20  0:24           ` George Anzinger
2005-01-20  8:04             ` Tony Lindgren
2005-01-20 23:10               ` George Anzinger
2005-01-21 17:35                 ` Tony Lindgren
2005-01-21 20:23                   ` George Anzinger
2005-01-19 23:26         ` Thomas Gleixner
2005-01-19 23:45           ` john stultz
2005-01-20  5:56             ` Thomas Gleixner
2005-01-20  0:39           ` George Anzinger
2005-01-20  3:15         ` Valdis.Kletnieks
2005-01-19 11:36 ` Pavel Machek
2005-01-19 17:11   ` Tony Lindgren
2005-01-19 17:30     ` Arjan van de Ven
2005-01-19 17:41       ` Tony Lindgren
2005-01-19 22:06     ` Pavel Machek
2005-01-19 23:08       ` Tony Lindgren
2005-01-19 23:46         ` Pavel Machek
2005-01-19 23:53           ` Tony Lindgren
2005-01-19 23:59         ` Pavel Machek
2005-01-20  0:07           ` Tony Lindgren
2005-01-20  0:44             ` Pavel Machek
2005-01-20  0:54             ` Pavel Machek
2005-01-20  7:39               ` Tony Lindgren
2005-01-19 22:20     ` Pavel Machek
2005-01-20  4:02 ` Zwane Mwaikambo
2005-01-21 17:48   ` Tony Lindgren
2005-01-21 18:27     ` Zwane Mwaikambo
2005-01-21 18:38       ` Tony Lindgren
2005-01-21 18:54       ` Pavel Machek
2005-01-21 21:23         ` Zwane Mwaikambo
2005-01-21 21:29           ` Pavel Machek
2005-01-21 20:25       ` George Anzinger
2005-01-21 21:38         ` Zwane Mwaikambo
2005-01-22  7:24           ` George Anzinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1106118532.5295.3.camel@gaston \
    --to=benh@kernel.crashing.org \
    --cc=andrea@suse.de \
    --cc=george@mvista.com \
    --cc=johnstul@us.ibm.com \
    --cc=kernel@kolivas.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=schwidefsky@de.ibm.com \
    --cc=tony@atomide.com \
    --cc=zwane@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox