public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <djwong@us.ibm.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Suparna Bhattacharya <suparna@in.ibm.com>,
	Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-aio@kvack.org
Subject: Re: [PATCH] BUG in io_destroy (fs/aio.c:1248)
Date: Mon, 24 Jan 2005 16:43:21 -0800	[thread overview]
Message-ID: <1106613801.11633.2.camel@localhost.localdomain> (raw)
In-Reply-To: <20050124155613.3a741825.akpm@osdl.org>

Andrew Morton wrote:

> So...  Will someone be sending a new patch?

Here's a cheesy patch that simply marks the ioctx as dead before
destroying it.  Though I'd like to simply mark the ioctx as dead until
it actually gets used, I don't know enough about the code to make that
sort of invasive change.

--D

-----------------
Signed-off-by: Darrick Wong <djwong@us.ibm.com>

--- linux-2.6.10/fs/aio.c.old	2005-01-24 16:12:46.000000000 -0800
+++ linux-2.6.10/fs/aio.c	2005-01-24 16:30:53.000000000 -0800
@@ -1285,6 +1285,10 @@
 		if (!ret)
 			return 0;
 
+		spin_lock_irq(&ctx->ctx_lock);
+		ctx->dead = 1;
+		spin_unlock_irq(&ctx->ctx_lock);
+
 		io_destroy(ioctx);
 	}


  parent reply	other threads:[~2005-01-25  0:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-21  0:31 [PATCH] BUG in io_destroy (fs/aio.c:1248) Darrick J. Wong
2005-01-24  8:58 ` Suparna Bhattacharya
     [not found]   ` <20050124155613.3a741825.akpm@osdl.org>
2005-01-25  0:43     ` Darrick J. Wong [this message]
2005-01-25  0:58       ` Andrew Morton
2005-01-25  1:56         ` Daniel McNeil
2005-01-25  3:23       ` Suparna Bhattacharya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1106613801.11633.2.camel@localhost.localdomain \
    --to=djwong@us.ibm.com \
    --cc=akpm@osdl.org \
    --cc=linux-aio@kvack.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=suparna@in.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox