From: Rusty Russell <rusty@rustcorp.com.au>
To: Jesper Juhl <juhl-lkml@dif.dk>
Cc: Brian Gerst <bgerst@didntduck.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] micro optimization in kernel/params.c; don't call to_module_kobject before we really have to.
Date: Mon, 31 Jan 2005 14:43:42 +1100 [thread overview]
Message-ID: <1107143023.28143.9.camel@localhost.localdomain> (raw)
In-Reply-To: <Pine.LNX.4.62.0501301307260.2731@dragon.hygekrogen.localhost>
On Sun, 2005-01-30 at 13:43 +0100, Jesper Juhl wrote:
> True, the compiler is free to be clever, but I still think it's best to
> write the code in the most optimal way as seen from a C perspective.
> I just took a look at the compiled object files with and without the
> patch, and it makes no difference what-so-ever - gcc generates the exact
> same code. So you are right, gcc is clever about it.
If the code were not already in the kernel, I'd probably apply this.
However, cleanups this trivial are not worthwhile IMHO.
Rusty.
--
A bad analogy is like a leaky screwdriver -- Richard Braakman
prev parent reply other threads:[~2005-01-31 3:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-29 23:45 [PATCH] micro optimization in kernel/params.c; don't call to_module_kobject before we really have to Jesper Juhl
2005-01-30 0:13 ` Brian Gerst
2005-01-30 12:43 ` Jesper Juhl
2005-01-31 3:43 ` Rusty Russell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1107143023.28143.9.camel@localhost.localdomain \
--to=rusty@rustcorp.com.au \
--cc=bgerst@didntduck.org \
--cc=juhl-lkml@dif.dk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox