From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: Pavel Machek <pavel@suse.cz>,
Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [ide-dev 3/5] generic Power Management for IDE devices
Date: Wed, 02 Feb 2005 10:24:48 +1100 [thread overview]
Message-ID: <1107300288.1665.33.camel@gaston> (raw)
In-Reply-To: <58cb370e05020115032fdb8b59@mail.gmail.com>
On Wed, 2005-02-02 at 00:03 +0100, Bartlomiej Zolnierkiewicz wrote:
> On Sat, 22 Jan 2005 19:41:24 +0100, Pavel Machek <pavel@suse.cz> wrote:
> > Hi!
> >
> > > Move PM code from ide-cd.c and ide-disk.c to IDE core so:
> > > * PM is supported for other ATAPI devices (floppy, tape)
> > > * PM is supported even if specific driver is not loaded
> >
> > Why do you need to have state-machine? During suspend we are running
> > single-threaded, it should be okay to just do the calls directly.
> > Pavel
>
> If we are running single-threaded I also see no reason for state-machine.
> Ben?
>
> Pavel, I assume that changes contained in the patch are OK with you?
We aren't always running single threaded. On PPC we are definitely
not :)
Also, we need the request to go down the queue for proper
synchronisation. It's all been discussed at lenght a while ago, this is
the best way to do it. Also, wakeup can be asynchronous this way.
Ben.
next prev parent reply other threads:[~2005-02-01 23:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-21 23:05 [ide-dev 3/5] generic Power Management for IDE devices Bartlomiej Zolnierkiewicz
2005-01-22 18:41 ` Pavel Machek
2005-02-01 23:03 ` Bartlomiej Zolnierkiewicz
2005-02-01 23:24 ` Pavel Machek
2005-02-01 23:24 ` Benjamin Herrenschmidt [this message]
2005-02-01 23:29 ` Pavel Machek
2005-02-03 10:03 ` Alan Cox
2005-02-03 13:34 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1107300288.1665.33.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=bzolnier@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox