From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Andrew Morton <akpm@osdl.org>
Cc: rmk+lkml@arm.linux.org.uk, e9925248@student.tuwien.ac.at,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Deadlock in serial driver 2.6.x
Date: Thu, 03 Feb 2005 10:02:54 +0000 [thread overview]
Message-ID: <1107332396.14847.112.camel@localhost.localdomain> (raw)
In-Reply-To: <20050131004857.07f5e2c4.akpm@osdl.org>
On Llu, 2005-01-31 at 08:48, Andrew Morton wrote:
> > The tty layer cannot fix this for now, and I don't intend to fix it. Fix
> > the serial driver: the fix is quite simple since you can keep a field in
> > the driver for now to detect recursive calling into the echo case and
> > don't relock.
>
> Are we sure that the serial driver is the only one which will hit this
> deadlock?
Yes fairly sure. The feature has been a well known but non-documented
property of the tty layer since about 1.0. There are two ways I see to
clean it up - we
can have the serial driver behave like other drivers and if need be
known about
recursive entries or we could extend the driver interface with an "echo"
method used by line disciplines when calling back to the tty driver from
a data
receive event.
Alan
next prev parent reply other threads:[~2005-02-03 11:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-26 13:20 Deadlock in serial driver 2.6.x Martin Kögler
2005-01-27 7:13 ` Andrew Morton
2005-01-30 15:39 ` Alan Cox
2005-01-30 16:48 ` Russell King
2005-01-31 7:37 ` Alan Cox
2005-01-31 8:48 ` Andrew Morton
2005-02-03 10:02 ` Alan Cox [this message]
2005-02-03 18:21 ` Andrew Morton
2005-02-04 11:07 ` Martin Kögler
2005-02-04 13:50 ` Paul Fulghum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1107332396.14847.112.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@osdl.org \
--cc=e9925248@student.tuwien.ac.at \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk+lkml@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox